Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change README header to Markdown only (again) #695

Merged
merged 3 commits into from
Mar 15, 2018
Merged

Change README header to Markdown only (again) #695

merged 3 commits into from
Mar 15, 2018

Conversation

faustinoaq
Copy link
Contributor

Description of the Change

Make README more compatible with other platforms like Docker

Alternate Designs

No

Benefits

Fix this:

screenshot_20180111_124534

Possible Drawbacks

No

Please see: #501 (comment)

@faustinoaq
Copy link
Contributor Author

Here we go 😅

github com_amberframework_amber_blob_f8d9fff3daab376bab59c3ff673c86786b3e83b8_readme md

I replaced centered logo by an horizontal aligned one

I think it looks good enough and uses Markdown only.

@faustinoaq faustinoaq requested a review from a team March 14, 2018 14:35
elorest
elorest approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@elorest elorest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a worthy compromise.

@eliasjpr eliasjpr merged commit ad0205f into master Mar 15, 2018
@eliasjpr eliasjpr deleted the fa/change-readme-header branch March 15, 2018 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elorest elorest elorest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@faustinoaq @elorest @eliasjpr