[CORS] Fixes Cors Headers with Case Insensitive Matching #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #757 This solves two issues with CORS: Headers currently are not checking case-insensitive values for `Access-Control-Request-Headers`. Allowed headers should match against `Access-Control-Request-Headers` values. There was the belief that `response.flush` writes the contents of the response halting the request, this is not true, instead the request is continuing the pipeline. - Adds case insensitive check to `Access-Control-Request-Headers` - Validates that `Access-Control-Request-Headers` values match against ALLOWED_HEADERS - Adds invalid preflight specs. - Prevents call next for preflight requests With these changes in the event of preflight requests should respond to case insensitive preflight headers and the `call_next` should not be called.
robacarp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #757
Description of the Change
This solves two issues with CORS:
Headers currently are not checking case-insensitive values for
Access-Control-Request-Headers. Allowed headers should matchagainst
Access-Control-Request-Headersvalues.There was the belief that
response.flushwrites the contents of theresponse halting the request, this is not true, instead the request is
continuing the pipeline.
Changes
Access-Control-Request-HeadersAccess-Control-Request-Headersvalues match againstALLOWED_HEADERS
Benefits
With these changes in the event of preflight requests should
respond to case insensitive preflight headers and the
call_nextshould not be called.