Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change confusing puts to info and add error logger #796

Merged
merged 14 commits into from
May 27, 2018
Merged

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented May 17, 2018

Description of the Change

This PR does:

  • Removes puts to call Amber logger because is a bit confusing.
  • Encourages to use info and error as shortcut for CLI.logger
  • Adds missing toggle_colors for some sub commands with already existent --no-color flag
  • Encourages to use exit! method from cli shard on cli commands, See: Explicit Exit

Alternate Designs

No

Benefits

Logger usage more explicit

Can use stdlib puts without ::puts or STDOUT.puts

Possible Drawbacks

No

@robacarp robacarp changed the title Change confusing puts by info and add error logger Change confusing puts to info and add error logger May 18, 2018
@drujensen drujensen merged commit 60db602 into master May 27, 2018
@drujensen drujensen deleted the fa/improve-logs branch May 27, 2018 15:28
@faustinoaq faustinoaq mentioned this pull request May 27, 2018
@faustinoaq faustinoaq added this to the Version 0.8.0 milestone Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants