fixes not_nil runtime exception in json parser #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacarp
reviewed
May 23, 2018
fridgerator
force-pushed
the
nf/json_null_body
branch
from
40f208e to
7c193e1
Compare
|
Parser specs did not exist, so I created a JSON parser spec and tested for both nil and not nil request body types |
faustinoaq
approved these changes
May 27, 2018
drujensen
approved these changes
May 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes #800
It is possible for the request body to be nil with a JSON request (DELETE request for example), causing Amber to log a 200 response whereas the actual response in the browser is 500.
This change checks for existence rather than using
not_nil!.