Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for amber deploy #862

Merged
merged 4 commits into from
Jun 21, 2018
Merged

Removes support for amber deploy #862

merged 4 commits into from
Jun 21, 2018

Conversation

faustinoaq
Copy link
Contributor

@faustinoaq faustinoaq commented Jun 16, 2018

Description of the Change

This PR removes support for amber deploy because it can be an external shard and we use raw tools (docker-machine, heroku cli) to deploy to production.

Another reason is that amber deploy may be too complex to maintain because providers and developers have different ways to do production deployments (size, resources, accounts, keys, auth, etc)

New deploy guides are already WIP, please, see: https://amberframework.gitbook.io/amber/deployments

Alternate Designs

No

Benefits

Fixes #767
Fixes #768
Fixes #769

Possible Drawbacks

No (DO was already broken) 😅

@faustinoaq faustinoaq requested a review from a team June 16, 2018 17:44
@faustinoaq faustinoaq requested a review from a team June 16, 2018 18:43
@faustinoaq faustinoaq changed the title Drop amber deploy Removes support for amber deploy Jun 16, 2018
eliasjpr
eliasjpr previously approved these changes Jun 21, 2018
Copy link
Contributor

@eliasjpr eliasjpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remove from docs and Readme file as well, I believe also the default command has reference to this.

I guess you can search for the deploy keyword in the source code

@eliasjpr eliasjpr dismissed their stale review June 21, 2018 01:27

Dismissing until you can confirm that we have removed all references

@faustinoaq
Copy link
Contributor Author

@eliasjpr I already searched the keywork "deploy" across all amber source code and I just found this file 😅

Also I added a warning on amber documentation, see: https://docs.amberframework.org/amber/cli/deploy

@faustinoaq faustinoaq merged commit 4504b6a into master Jun 21, 2018
@faustinoaq faustinoaq deleted the fa/drop-amber-deploy branch June 21, 2018 07:21
@faustinoaq faustinoaq added this to the Version 0.8.0 milestone Jun 21, 2018
@gokul-hashlearn
Copy link

"New deploy guides are already WIP, please, see: https://amberframework.gitbook.io/amber/deployments"
The above URL is a 404.

@faustinoaq
Copy link
Contributor Author

faustinoaq commented Jun 22, 2018

@gokul-hashlearn Yeah, we just added a custom domain, please see: https://docs.amberframework.org/amber/deployment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants