-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes support for amber deploy #862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to remove from docs and Readme file as well, I believe also the default command has reference to this.
I guess you can search for the deploy keyword in the source code
Dismissing until you can confirm that we have removed all references
@eliasjpr I already searched the keywork Also I added a warning on amber documentation, see: https://docs.amberframework.org/amber/cli/deploy |
"New deploy guides are already WIP, please, see: https://amberframework.gitbook.io/amber/deployments" |
@gokul-hashlearn Yeah, we just added a custom domain, please see: https://docs.amberframework.org/amber/deployment 👍 |
Description of the Change
This PR removes support for
amber deploy
because it can be an external shard and we use raw tools (docker-machine
,heroku
cli) to deploy to production.Another reason is that
amber deploy
may be too complex to maintain because providers and developers have different ways to do production deployments (size, resources, accounts, keys, auth, etc)New deploy guides are already WIP, please, see: https://amberframework.gitbook.io/amber/deployments
Alternate Designs
No
Benefits
Fixes #767
Fixes #768
Fixes #769
Possible Drawbacks
No (DO was already broken) 😅