Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing the container div for application.ecr template. #894

Merged
merged 3 commits into from
Jun 25, 2018

Conversation

shobhitic
Copy link
Contributor

Description of the Change

A container div was left open in application.ecr template. Adding the closing tag.

Alternate Designs

None.

Benefits

Whenever the application.ecr file was generated, it had a container div which remained open. Closing it giver us better code, avoiding hard to find and fix mistakes later.

Possible Drawbacks

None.

@faustinoaq faustinoaq requested review from robacarp, elorest and a team June 25, 2018 11:32
Copy link
Member

@robacarp robacarp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shobhitic

@robacarp robacarp merged commit d6ab4c5 into amberframework:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants