feat: fall-detect initialization #14

bhavikapanara · 2021-04-21T13:28:17Z

This PR is initialization of stand-alone fall detect python package

Run python file for fall-detection: python3 demo-fall-detection.py

To test fall-detection using the command line for 2 images:
python3 demo-fall-detection-cmd.py --image_1 Images/fall_img_1.png --image_2 Images/fall_img_2.png

To test fall-detection using the command line for 3 images:
python3 demo-fall-detection-cmd.py --image_1 Images/fall_img_1.png --image_2 Images/fall_img_2.png --image_3 Images/fall_img_3.png

Use Demo.ipynb jupyter-notebook for the experiment.

commit-lint · 2021-04-21T13:28:21Z

Contributors

bhavikapanara

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

ivelin

@bhavikapanara you've copied virtually all the code from the ambianic-edge repo. This is not at all the goal here.

Please remove all files and refactor fall detection classes as needed. If there is any code that is not directly involved in the fall detection algorithm, then it does not belong in this repo.

You should also have a very clear plan and design how ambianic-edge will import and use the fall-detection python package.

Please prepare a design document so we can align on high level goals. I usually use diagrams.net for design diagrams but you can use any similar tool that you like.

bhavikapanara · 2021-04-26T17:29:03Z

@bhavikapanara you've copied virtually all the code from the ambianic-edge repo. This is not at all the goal here.

Please remove all files and refactor fall detection classes as needed. If there is any code that is not directly involved in the fall detection algorithm, then it does not belong in this repo.

You should also have a very clear plan and design how ambianic-edge will import and use the fall-detection python package.

Please prepare a design document so we can align on high level goals. I usually use diagrams.net for design diagrams but you can use any similar tool that you like.

@ivelin Yes...I have tried to consider the only code that is directly involved in fall detection. However, again I will recheck it and refactor fall detection classes if require.

And, Will prepare the design document and get back to you.

review-notebook-app · 2021-04-30T06:26:52Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

ivelin

@bhavikapanara this looks better.

There is only one file that seems unnecessary: .peerjsrc

Can you please share your forked repo for this PR with CI passing so I can see what the master repo would look like after merge?

.peerjsrc

ivelin · 2021-05-03T20:47:01Z

@bhavikapanara I don't see a README.md for the repo. Why was it deleted?

ivelin

@bhavikapanara commented on a few more areas that need work.

LICENSE

README.md

bhavikapanara · 2021-05-05T09:31:11Z

@bhavikapanara I don't see a README.md for the repo. Why was it deleted?

Ohh...by mistake it deleted. you can see it in the next update.

bhavikapanara · 2021-05-05T16:59:49Z

@bhavikapanara commented on a few more areas that need work.

tried to cover all comments in the latest update...Please review it and let me know if I missed anything.

ivelin

@bhavikapanara nice progress.

Next, lets work on the following items:

port fall detector tests from edge to this repo
write a github action with the following jobs:
- build
- run tests
- run semantic release to push a pypi package as needed

You can borrow most of the steps from the peerjs-python github action.

The semantic release section is now available via more compact github action plugin that we use in the edge CI.

ivelin

Some work remains on dependency cleanup and common code reuse between repos.

requirements.txt

ivelin · 2021-05-22T18:51:11Z

requirements.txt

+numpy>=1.16.2
+oauthlib>=2.1.0
+Pillow>=5.4.1
+pyOpenSSL>=19.0.0


@bhavikapanara are you sure we need pyopenSSL?

@bhavikapanara take a look at tools that help clean up requirements.txt
https://pypi.org/project/pip-check-reqs/

src/pipeline/tf_detect.py

ivelin

See additional comments.

Please comment how you think about using this standalone library in ambianic-edge. What is the API that will be used by edge for this model and potentially other standalone AI models?

ivelin · 2021-05-31T23:12:38Z

src/setup.cfg

+[metadata]
+name = ambianic-fall-detection
+version = 1.0.0
+author = Ivelin Ivanov


@bhavikapanara add your name to the authors list

ivelin · 2021-05-31T23:18:08Z

requirements.txt

+oauthlib>=2.1.0
+Pillow>=5.4.1
+PyYAML>=5.1.2
+requests>=2.25


@bhavikapanara do we need requests, requests-oauthlib, responses, simplejson, oauthlib, matplotlib, h5py, gast, appdirs, absl-py ?

Please do a thorough cleanup to ensure there are no unused packages in requirements.txt.

bhavikapanara · 2021-06-02T03:38:13Z

See additional comments.

Please comment how you think about using this standalone library in ambianic-edge. What is the API that will be used by edge for this model and potentially other standalone AI models?

we can use the Fall_prediction method (exist in fall_prediction.py) with pipeline image 2 or 3. Similar to the demo example demo-fall-detection.py. I think this is one way to call this fall-detect stand-alone package in ambianic-edge.

@ivelin Please guide me if any other good method that we can implement.

ivelin · 2021-06-02T15:28:39Z

OK, can you please show me a few lines of pseudo code. Which class in the ambianic edge will interact with the fall detector package?

…

On Tue, Jun 1, 2021 at 10:38 PM bhavika panara ***@***.***> wrote: See additional comments. Please comment how you think about using this standalone library in ambianic-edge. What is the API that will be used by edge for this model and potentially other standalone AI models? we can use the Fall_prediction method (exist in fall_prediction.py) with pipeline image 2 or 3. Similar to the demo example demo-fall-detection.py. I think this is one way to call this fall-detect stand-alone package in ambianic-edge. Please guide me if any other good method that we can implement. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARBUFKPVWOYU2BDFD6ISHDTQWRTFANCNFSM43KLVPMQ> .

bhavikapanara · 2021-06-05T18:28:44Z

after brainstorming with the goal I found one possible way to integrate an ambianic-edge with the fall-detect module.

We can directly attach an ambianic-edge pipeline with a fall-detect module and call the fall_detection process on the receive_next_sample() method of PipeElement

def receive_next_sample(self, **sample):

Here is an example to call fall-detect module: Link

ivelin · 2021-06-08T14:08:30Z

after brainstorming with the goal I found one possible way to integrate an ambianic-edge with the fall-detect module.

We can directly attach an ambianic-edge pipeline with a fall-detect module and call the fall_detection process on the receive_next_sample() method of PipeElement

def receive_next_sample(self, **sample):

Here is an example to call fall-detect module: Link

Yes, that seems like a sensible approach.

ivelin

@bhavikapanara I don't see codecoverage reporting in the CI.

ivelin

@bhavikapanara
OK, let's give it a shot. Please be on standby for potential issues we have not caught in the review process.

bhavikapanara · 2021-06-15T05:53:59Z

@bhavikapanara
OK, let's give it a shot. Please be on standby for potential issues we have not caught in the review process.

yes...sure @ivelin
Thanks

# 1.0.0 (2021-10-03) ### Bug Fixes * python setup files ([#23](#23)) ([41ee60d](41ee60d)) ### Features * add MoveNet and PoseNet notebooks for experiment ([916271e](916271e)) * add plot title for video seq ([db3d7c2](db3d7c2)) * add tflite model training and inference ([#33](#33)) ([3e7658c](3e7658c)) * add video samples to notebook ([702b334](702b334)) * fall detect pypi publishing ([#32](#32)) ([87f1751](87f1751)) * fall-detect initialization ([6e439aa](6e439aa)), closes [#14](#14) ### Performance Improvements * [ImgBot] Optimize images ([#19](#19)) ([a489885](a489885))

github-actions · 2021-10-03T18:30:37Z

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fall-detect repo initialization

fc2944b

add test_avsource.py

5c1e682

bhavikapanara requested a review from ivelin April 22, 2021 18:08

ivelin marked this pull request as draft April 23, 2021 19:10

ivelin requested changes Apr 23, 2021

View reviewed changes

update code

6311fee

bhavikapanara marked this pull request as ready for review April 30, 2021 06:34

ivelin requested changes May 3, 2021

View reviewed changes

.peerjsrc Outdated Show resolved Hide resolved

ivelin requested changes May 3, 2021

View reviewed changes

LICENSE Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

README.md Show resolved Hide resolved

bhavikapanara added 7 commits May 5, 2021 15:09

add readme & License files

48adea7

remove .peerjsrc file

087d9d2

update readme

74daa9e

update readme

fab44a3

.

be6481a

update

5cf21de

readme updatation

5e259d1

bhavikapanara requested a review from ivelin May 5, 2021 17:00

ivelin requested changes May 5, 2021

View reviewed changes

bhavikapanara added 6 commits May 10, 2021 10:09

add test fall detect file

9b17a82

add github actions

9e32f01

add setup.py file

ae76928

update action file

c548fd7

update

b740e5d

update

66fc481

bhavikapanara requested a review from ivelin May 18, 2021 18:13

ivelin requested changes May 22, 2021

View reviewed changes

bhavikapanara added 3 commits May 24, 2021 17:21

update requirements.py

d86314e

update requirements.py

2dd4943

update code

97e7116

bhavikapanara requested a review from ivelin May 26, 2021 15:20

ivelin requested changes May 31, 2021

View reviewed changes

bhavikapanara added 3 commits June 2, 2021 08:45

update code

c4d8159

update code

d9dc40b

update requirement.txt file

06894c0

bhavikapanara requested a review from ivelin June 7, 2021 11:53

ivelin requested changes Jun 8, 2021

View reviewed changes

bhavikapanara added 7 commits June 10, 2021 17:20

update

85b7103

upadte

c94ce4f

add CODECOV_TOKEN

1edb67b

update

bd30b04

update

e8ce583

update

3ce79c7

add test case for fall_prediction.py file

fefece1

bhavikapanara requested a review from ivelin June 14, 2021 18:09

ivelin approved these changes Jun 14, 2021

View reviewed changes

ivelin merged commit 6e439aa into ambianic:main Jun 14, 2021

github-actions bot added the released label Oct 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fall-detect initialization #14

feat: fall-detect initialization #14

bhavikapanara commented Apr 21, 2021 •

edited

Loading

commit-lint bot commented Apr 21, 2021

ivelin left a comment

bhavikapanara commented Apr 26, 2021

review-notebook-app bot commented Apr 30, 2021

ivelin left a comment

ivelin commented May 3, 2021

ivelin left a comment

bhavikapanara commented May 5, 2021

bhavikapanara commented May 5, 2021

ivelin left a comment

ivelin left a comment

ivelin May 22, 2021

ivelin May 22, 2021

ivelin left a comment

ivelin May 31, 2021

bhavikapanara Jun 2, 2021

ivelin May 31, 2021

bhavikapanara Jun 2, 2021

bhavikapanara commented Jun 2, 2021 •

edited

Loading

ivelin commented Jun 2, 2021 via email

bhavikapanara commented Jun 5, 2021 •

edited

Loading

ivelin commented Jun 8, 2021

ivelin left a comment

ivelin left a comment

bhavikapanara commented Jun 15, 2021

github-actions bot commented Oct 3, 2021

feat: fall-detect initialization #14

feat: fall-detect initialization #14

Conversation

bhavikapanara commented Apr 21, 2021 • edited Loading

commit-lint bot commented Apr 21, 2021

Contributors

ivelin left a comment

Choose a reason for hiding this comment

bhavikapanara commented Apr 26, 2021

review-notebook-app bot commented Apr 30, 2021

ivelin left a comment

Choose a reason for hiding this comment

ivelin commented May 3, 2021

ivelin left a comment

Choose a reason for hiding this comment

bhavikapanara commented May 5, 2021

bhavikapanara commented May 5, 2021

ivelin left a comment

Choose a reason for hiding this comment

ivelin left a comment

Choose a reason for hiding this comment

ivelin May 22, 2021

Choose a reason for hiding this comment

ivelin May 22, 2021

Choose a reason for hiding this comment

ivelin left a comment

Choose a reason for hiding this comment

ivelin May 31, 2021

Choose a reason for hiding this comment

bhavikapanara Jun 2, 2021

Choose a reason for hiding this comment

ivelin May 31, 2021

Choose a reason for hiding this comment

bhavikapanara Jun 2, 2021

Choose a reason for hiding this comment

bhavikapanara commented Jun 2, 2021 • edited Loading

ivelin commented Jun 2, 2021 via email

bhavikapanara commented Jun 5, 2021 • edited Loading

ivelin commented Jun 8, 2021

ivelin left a comment

Choose a reason for hiding this comment

ivelin left a comment

Choose a reason for hiding this comment

bhavikapanara commented Jun 15, 2021

github-actions bot commented Oct 3, 2021

bhavikapanara commented Apr 21, 2021 •

edited

Loading

bhavikapanara commented Jun 2, 2021 •

edited

Loading

bhavikapanara commented Jun 5, 2021 •

edited

Loading