Skip to content

Commit

Permalink
Always clean airflow installation in provider's compatibility tests (a…
Browse files Browse the repository at this point in the history
…pache#46693)

So far cleaning airflow installation only happened in canary runs
and it caused some PRs not failing when they should - for exmaple
the apache#45294 was green when it should fail because uuid6 package was
not removed before installing old version of Airlfow.

Cleaning airflow installation is fast with uv so we should be
ok with running it always for compatibility tests.
  • Loading branch information
potiuk authored and ambika-garg committed Feb 13, 2025
1 parent 62205b6 commit c0e00bc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion .github/workflows/task-sdk-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ jobs:
INCLUDE_NOT_READY_PROVIDERS: "true"
PYTHON_MAJOR_MINOR_VERSION: "${{ inputs.default-python-version }}"
VERBOSE: "true"
CLEAN_AIRFLOW_INSTALLATION: "${{ inputs.canary-run }}"
steps:
- name: "Cleanup repo"
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-provider-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ jobs:
PYTHON_MAJOR_MINOR_VERSION: "${{ matrix.python-version }}"
VERSION_SUFFIX_FOR_PYPI: "dev0"
VERBOSE: "true"
CLEAN_AIRFLOW_INSTALLATION: "${{ inputs.canary-run }}"
CLEAN_AIRFLOW_INSTALLATION: "true"
if: inputs.skip-providers-tests != 'true'
steps:
- name: "Cleanup repo"
Expand Down

0 comments on commit c0e00bc

Please sign in to comment.