Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new target export template introduced with CMake 3.24 (backport #395) #398

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 11, 2022

This is an automatic backport of pull request #395 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@clalancette
Copy link
Contributor

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@clalancette
Copy link
Contributor

The failed tests on Windows seem unrelated to this PR, so going ahead and merging.

@clalancette clalancette merged commit 796cef7 into galactic Aug 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/galactic/pr-395 branch August 12, 2022 13:20
@tonynajjar
Copy link

Hi, I'm suspecting that this PR is causing this issue and a similar one I'm having:

Starting >>> bondcpp
--- stderr: bondcpp                            
CMake Error at /code/ros2_ws/install/bond/share/bond/cmake/ament_cmake_export_targets-extras.cmake:18 (message):
  Failed to find exported target names in
  '/code/ros2_ws/install/bond/share/bond/cmake/bond__rosidl_generator_cExport.cmake'
Call Stack (most recent call first):
  /code/ros2_ws/install/bond/share/bond/cmake/bondConfig.cmake:41 (include)
  CMakeLists.txt:13 (find_package)

I'm not so well versed in cmake. Could you please check if this could be related? Thanks

@clalancette
Copy link
Contributor

I'm not so well versed in cmake. Could you please check if this could be related? Thanks

It should be easy enough to test; revert this patch, and try it out. Does it work then?

@tonynajjar
Copy link

Fair enough. After further investigation, I think this is actually not the problem, it's the fix. The problematic systems have cmake 3.24 already and lack this backport. Anyway nothing to do here, sorry for the false alarm

cottsay pushed a commit that referenced this pull request Dec 8, 2022
…398)

Signed-off-by: Timo Röhling <[email protected]>
(cherry picked from commit ca8c26e)

Co-authored-by: Timo Röhling <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants