ament_add_gtest_test: add TEST_NAME parameter #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clalancette
requested changes
Nov 14, 2023
Comment on lines
30
to
31
| # :type WORKING_DIRECTORY: string | ||
| # :param SKIP_TEST: if set mark the test as being skipped |
There was a problem hiding this comment.
These two lines should restored (though the SKIP_TEST one should be moved after the new TEST_NAME option).
Comment on lines
31
to
32
| # :type TEST_NAME: string | ||
| # :param TEST_NAME: the name of the test |
There was a problem hiding this comment.
Suggested change
| # :type TEST_NAME: string | |
| # :param TEST_NAME: the name of the test | |
| # :param TEST_NAME: the name of the test, if different than the target name | |
| # :type TEST_NAME: string |
There was a problem hiding this comment.
Whoops. Fix that one.
Signed-off-by: Christopher Wecht <[email protected]>
cwecht
force-pushed
the
ament_add_gtest_test_test_name
branch
from
20249c9 to
e7bb66c
Compare
clalancette
approved these changes
Nov 14, 2023
|
CI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need for this change came up in ros2/rcl#1114.
The TEST_NAME parameter has beend added to ament_add_gtest_test which allos for adding multiple test cases for the same executable.