Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patch file dependencies in ament_cmake_vendor_package #520

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Fix patch file dependencies in ament_cmake_vendor_package #520

merged 1 commit into from
Mar 13, 2024

Conversation

cottsay
Copy link
Contributor

@cottsay cottsay commented Mar 13, 2024

When patch files are changed, re-download the sources to get a clean slate to re-apply the changed patch files.

@cottsay
Fix patch file dependencies in ament_cmake_vendor_package
cec0127 
When patch files are changed, re-download the sources to get a clean
slate to re-apply the changed patch files.

Signed-off-by: Scott K Logan <[email protected]>
@cottsay cottsay added the bug Something isn't working label Mar 13, 2024
@cottsay cottsay self-assigned this Mar 13, 2024
@cottsay cottsay requested a review from clalancette as a code owner March 13, 2024 16:13
clalancette
clalancette approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I like it. I'd just make sure to run full CI on this change (not that I expect anything to break, but still worthwhile doing, especially on Windows).

@cottsay
Copy link
Contributor Author

cottsay commented Mar 13, 2024

CI with every ament_cmake_vendor_package user:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@cottsay cottsay merged commit f44a937 into rolling Mar 13, 2024
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the cottsay/vendor-patch-fix branch March 13, 2024 20:59
roscan-tech pushed a commit to roscan-tech/ament_cmake that referenced this pull request Sep 6, 2024
@cottsay @roscan-tech
Fix patch file dependencies in ament_cmake_vendor_package (ament#520)
62d551b 
When patch files are changed, re-download the sources to get a clean
slate to re-apply the changed patch files.

Signed-off-by: Scott K Logan <[email protected]>
roscan-tech pushed a commit to roscan-tech/ament_cmake that referenced this pull request Sep 6, 2024
@cottsay @roscan-tech
Fix patch file dependencies in ament_cmake_vendor_package (ament#520)
2b96917 
When patch files are changed, re-download the sources to get a clean
slate to re-apply the changed patch files.

Signed-off-by: Scott K Logan <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 6, 2024
@roscan-tech @cottsay
Fix patch file dependencies in ament_cmake_vendor_package (#520) (#548)
10df8db 
When patch files are changed, re-download the sources to get a clean
slate to re-apply the changed patch files.

Signed-off-by: Scott K Logan <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
clalancette pushed a commit that referenced this pull request Sep 6, 2024
@roscan-tech @cottsay
Fix patch file dependencies in ament_cmake_vendor_package (#520) (#549)
d87f6f0 
When patch files are changed, re-download the sources to get a clean
slate to re-apply the changed patch files.

Signed-off-by: Scott K Logan <[email protected]>
Co-authored-by: Scott K Logan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees

@cottsay cottsay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @clalancette