Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NuGet packing of DXGI project #277

Merged
merged 1 commit into from
May 3, 2022

Conversation

andrew-boyarshin
Copy link
Contributor

No description provided.

@andrew-boyarshin
Copy link
Contributor Author

The question remains: how did it work before?

@amerkoleci
Copy link
Owner

Wow that was fast, thanks!

@amerkoleci amerkoleci merged commit 488d960 into amerkoleci:main May 3, 2022
@andrew-boyarshin andrew-boyarshin deleted the fix-pack branch May 3, 2022 08:58
@amerkoleci
Copy link
Owner

The question remains: how did it work before?

Maybe some PR changed the solution file, let me check

@andrew-boyarshin
Copy link
Contributor Author

@amerkoleci no. It was a long time ago.

@amerkoleci
Copy link
Owner

Not sure then :) Probably latest .NET 6.0 broke the build, anyway it was issue with DirectInput project.

@andrew-boyarshin
Copy link
Contributor Author

andrew-boyarshin commented May 3, 2022

Investigation closed: dotnet/msbuild#4303
It was due to the introduction of multitargetting (TargetFramework -> TargetFrameworks).
The fix in this PR is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants