Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if the Resources are empty #87

Closed
torkleyy opened this issue May 7, 2018 · 5 comments
Closed

Check if the Resources are empty #87

torkleyy opened this issue May 7, 2018 · 5 comments

Comments

@torkleyy
Copy link
Member

torkleyy commented May 7, 2018

If a resource couldn't be fetched and Resources is empty, it might be because somebody accidentally created a new instance by specifying it as SystemData. This should be pointed out in the panic.

@torkleyy
Copy link
Member Author

torkleyy commented May 7, 2018

cc @Moxinilian

@cedric-h
Copy link

cedric-h commented Mar 10, 2019

Would it also be reasonable to add some way to iterate over the types of resources stored? I recently found that I needed this, and somebody else on the specs github issues found that they needed this as well. (amethyst/specs#559)
Since it's stored in a hash map, that could actually be as simple as making the resources field public, although I'd prefer some other sort of API. If this is desirable, what would you recommend? I'm willing to write the PR.

@cedric-h
Copy link

cedric-h commented Mar 10, 2019

I could also do the variable renaming part of #111 while I'm over there.
Well I guess that should be a different PR. Nevermind.

@torkleyy
Copy link
Member Author

Would it also be reasonable to add some way to iterate over the types of resources stored?

Yes, I think that would be useful, too. I think the simplest solution would be to just create a method that returns an iterator over the values, yielding &Resource. The keys aren't really interesting since they're just the type ids.

@torkleyy
Copy link
Member Author

@DefecateRainbows are you still interested in this?

bors bot added a commit that referenced this issue Mar 29, 2019
118: Print warning if `World` is completely empty r=torkleyy a=torkleyy

Fixes #87 

Co-authored-by: Thomas Schaller <[email protected]>
@bors bors bot closed this as completed in #118 Mar 29, 2019
bors bot added a commit that referenced this issue Jun 13, 2019
143: Update hashbrown requirement from 0.4.0 to 0.5.0 r=torkleyy a=dependabot-preview[bot]

Updates the requirements on [hashbrown](https://github.com/rust-lang/hashbrown) to permit the latest version.
<details>
<summary>Changelog</summary>

*Sourced from [hashbrown's changelog](https://github.com/rust-lang/hashbrown/blob/master/CHANGELOG.md).*

> ## [v0.5.0] - 2019-06-12
> 
> ### Fixed
> - Resize with a more conservative amount of space after deletions. ([#86](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/86))
> 
> ### Changed
> - Exposed the Layout of the failed allocation in CollectionAllocErr::AllocErr. ([#89](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/89))
> 
> ## [v0.4.0] - 2019-05-30
> 
> ### Fixed
> - Fixed `Send` trait bounds on `IterMut` not matching the libstd one. ([#82](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/82))
> 
> ## [v0.3.1] - 2019-05-30
> 
> ### Fixed
> - Fixed incorrect use of slice in unsafe code. ([#80](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/80))
> 
> ## [v0.3.0] - 2019-04-23
> 
> ### Changed
> - Changed shrink_to to not panic if min_capacity < capacity. ([#67](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/67))
> 
> ### Fixed
> - Worked around emscripten bug emscripten-core/emscripten-fastcomp#258. ([#66](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/66))
> 
> ## [v0.2.2] - 2019-04-16
> 
> ### Fixed
> - Inlined non-nightly lowest_set_bit_nonzero. ([#64](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/64))
> - Fixed build on latest nightly. ([#65](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/65))
> 
> ## [v0.2.1] - 2019-04-14
> 
> ### Changed
> - Use for_each in map Extend and FromIterator. ([#58](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/58))
> - Improved worst-case performance of HashSet.is_subset. ([#61](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/61))
> 
> ### Fixed
> - Removed incorrect debug_assert. ([#60](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/60))
> 
> ## [v0.2.0] - 2019-03-31
> 
> ### Changed
> - The code has been updated to Rust 2018 edition. This means that the minimum
>   Rust version has been bumped to 1.31 (2018 edition).
> 
> ### Added
> - Added `insert_with_hasher` to the raw_entry API to allow `K: !(Hash + Eq)`. ([#54](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/54))
> - Added support for using hashbrown as the hash table implementation in libstd. ([#46](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/46))
></tr></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- [`e7cd4a5`](rust-lang/hashbrown@e7cd4a5) Version 0.5.0
- [`2c16341`](rust-lang/hashbrown@2c16341) Auto merge of [#89](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/89) - SimonSapin:layout, r=Amanieu
- [`c2e26e7`](rust-lang/hashbrown@c2e26e7) Expose the Layout of the failed allocation in CollectionAllocErr::AllocErr
- [`14bb115`](rust-lang/hashbrown@14bb115) Auto merge of [#87](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/87) - josephrocca:patch-1, r=Amanieu
- [`80dc544`](rust-lang/hashbrown@80dc544) Add simple usage code
- [`b240ee0`](rust-lang/hashbrown@b240ee0) Auto merge of [#86](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/86) - edre:rehash, r=Amanieu
- [`afc20d7`](rust-lang/hashbrown@afc20d7) Resize with a more conservative amount of space when inserting after deletions.
- [`119f429`](rust-lang/hashbrown@119f429) Auto merge of [#84](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/84) - edre:bench, r=Amanieu
- [`8783490`](rust-lang/hashbrown@8783490) Update insert_erase benchmark to keep the table size constant.
- [`143609d`](rust-lang/hashbrown@143609d) Auto merge of [#83](https://github-redirect.dependabot.com/rust-lang/hashbrown/issues/83) - edre:bench, r=Amanieu
- Additional commits viewable in [compare view](rust-lang/hashbrown@v0.4.0...v0.5.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot-preview[bot] <dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants