Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date field to attendance query #73

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

chimnayajith
Copy link
Contributor

@chimnayajith chimnayajith commented Feb 27, 2025

Pull Request

Description

This PR adds support for querying attendance records by a specific

A new query attendanceByDate has been added that:

  • Takes a specific date as a required parameter
  • Returns attendance records for all members on that date
  • Includes member names along with attendance data using a JOIN between the Attendance and Member tables

Related Issues

Additional Notes

This is a prerequisite for an issue in amD (Link to amD issue).

@chimnayajith chimnayajith marked this pull request as draft February 27, 2025 14:30
@chimnayajith chimnayajith force-pushed the attendance-by-date branch 2 times, most recently from d4789d7 to 974a9b4 Compare February 27, 2025 14:42
@chimnayajith chimnayajith marked this pull request as ready for review February 27, 2025 14:42
@ivinjabraham
Copy link
Member

Please PR to develop, not main, from now on

@ivinjabraham ivinjabraham changed the base branch from main to develop February 28, 2025 06:38
@ivinjabraham
Copy link
Member

Please rebase this PR @chimnayajith

@chimnayajith chimnayajith force-pushed the attendance-by-date branch 2 times, most recently from 14058e7 to ebcc703 Compare February 28, 2025 07:48
@ivinjabraham
Copy link
Member

Why is clippy failing? I feel like I've fixed this before...

Supports fetching attendance for all members for a given date.

Fixes amfoss#72
@chimnayajith
Copy link
Contributor Author

chimnayajith commented Feb 28, 2025

Should pass the test now. The fix was this commit which was in main.

I have rebased on top of develop.

@ivinjabraham ivinjabraham merged commit 55d6e13 into amfoss:develop Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query Attendance by Date
2 participants