This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
style: change and apply spotless with indentation 4 spaces #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
reviewed
Jun 25, 2019
| totalLayout.setVisibility(View.VISIBLE); | ||
| flag = 0; | ||
| Toast.makeText( | ||
| getBaseContext(), getString(R.string.delete_donated), Toast.LENGTH_LONG) |
There was a problem hiding this comment.
This seems like too much indentation. I think 2 space indentation is good enough.
There was a problem hiding this comment.
Those has to be in same line. I guess that is the reason it is giving that big indentation.
Else everything is fine.
There was a problem hiding this comment.
Yeah, I saw other changes too. I thought that 4 tabs are too much. According to me, 2 are enough.
yashk2000
reviewed
Jun 25, 2019
| radioGroup = (RadioGroup) findViewById(R.id.radiogroup); | ||
|
|
||
| radioGroup.setOnCheckedChangeListener( | ||
| new RadioGroup.OnCheckedChangeListener() { |
There was a problem hiding this comment.
For instance here. 4 tabs are too much. 2 are enough.
immadisairaj
commented
Jun 25, 2019
| private EditText uid1ET; | ||
|
|
||
| protected void onCreate(Bundle savedInstanceState) { | ||
| super.onCreate(savedInstanceState); |
There was a problem hiding this comment.
@yashk2000 suppose if you see here 2 space indentation doesn't look good
|
@immadisairaj yes. I viewed it in andorid studio. There is looks better 👍 |
yashk2000
approved these changes
Jun 25, 2019
immadisairaj
force-pushed
the
development
branch
from
47e661f to
f054de6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #63
Changes:
Changed the spotless style in gradle
applied spotless
removed unnecessary typecasting
made xml files in proper format