Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to original import-gpg GitHub action #129

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Switch to original import-gpg GitHub action #129

merged 1 commit into from
Jan 21, 2022

Conversation

BuJo
Copy link
Collaborator

@BuJo BuJo commented Jan 21, 2022

  • Updates to the latest import-gpg GitHub action.
  • Switches from slightly outdated fork to the original repository.
  • Allows signing-only keys in releases.

@BuJo
github, switch to original gpg ghaction
7a23aa6 
Allows signing-only keys.
@felladrin
Copy link
Collaborator

I just noticed we could remove the reference to the old GitHub action name from

terraform-provider-minio/.github/workflows/release.yml

Line 4 in 7a23aa6

# This uses an action (paultyng/ghaction-import-gpg) that assumes you set your

I think it's better to remove than replace it with the new one. It's hard to spot it in the comment.

@aminueza
Copy link
Owner

aminueza commented Jan 21, 2022 •
edited
Loading

We can fix it later, I'm going to merge it now

@aminueza aminueza merged commit 1051b42 into aminueza:master Jan 21, 2022
@BuJo BuJo deleted the ghaction_fix branch January 22, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felladrin felladrin felladrin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BuJo @felladrin @aminueza