Bucket import acl #130
Merged
Bucket import acl #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Progress Note: A basic import with a bucket having no bucket policy works ( |
* prepares local builds for debuggability via delve
* To be able to use bucket policy functions, the policy Statement types have to be used.
* Use awspolicyequivalence to verify policy names * Add PublicRead policy
|
Alright, this can be reviewed. I have removed the exclusions for |
felladrin
approved these changes
Mar 22, 2022
|
The code is clear, and everything I tested worked great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bucket import handling to not force bucket recreation due to changes in the
aclfield.The way
mc(or rationminio) detects theaclname is... horrible? But I think this way could work. I'm not sure about using theminiointernals insidepayload.gois wanted.. It's already used forStringSet, so I think it should be ok?The tests are good, but I haven't run it for real yet.