Capability to manage MinIO object #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HI @tomasherout . I totally missed your pull request. I was away from Github. Thank you for your work and I'm going to approve and make this repository active again |
|
@felladrin please, could you review this PR? |
…t, and separate build/install tasks to speed them up Note: the "install" task moves the plugin to the directory "~/.terraform.d/plugins/<OS>_<ARCH>", as described here: https://www.terraform.io/docs/extend/how-terraform-works.html#plugin-locations
felladrin
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Looks good!
I've renamed the resource file, updated the Makefile, and incremented the "bucket example" to add files to the bucket using this new resource. Is it ok for you?
We need to add tests (resource_minio_s3_object_test.go) for it later, but I believe we can merge it already.
aminueza
changed the title
|
Can you add documentation for this resource? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've made simple resouce for #54
Also, I made upgrade to minio-go v7
Can you look on ti?