Cleanup logging #255
Closed
Cleanup logging #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 13, 2015 22:27
None in particular would cause an exception through on creation of a sub-context.
Remove context from the 'command' logger to reduce verbosity & duplication. Have the child process logger include just the pid as context. Have the parent print the full command that was executed. This reduces the length of the log-line (& thus noise) signficantly & ensures that the entire command is logged (which makes it useful for debugging).
|
Sample output: |
This lets you copy-paste the output which is convenient when debugging these sorts of programs.
|
I was just about to go implement this as the current What I want is simply a full synopsis of the command being executed, just as is implemented in this pull request. What needs to happen to get this merged? |
|
+1 on this functionality |
|
I made some very similar changes for #323. They're in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures, particularly with executables living in long paths, that we don't have uninteresting log context spamming the log lines. Printing a truncated version of the command & the call args on every log-line is just spam. Also, it makes sure that the INFO message that gets printed contains the full command that was executed & with whitespace escaped properly so that you can copy directly from the log-line & paste.