DavRich-Recipe-App working prototype #24

amon-cofie · 2023-02-18T11:20:38Z

In this pull request my partner, @RichardChileya, and I, @amon-cofie did the following things listed in the project requirements:

- You should follow the layout of the wireframes provided. You should personalize the rest of the design including colors, typographies, spacings, etc.
- Login page and registration page:
  - Should be built with Devise.
- Food list:
  - Should display a list of food added by the logged-in user as in the wireframe (for teams with only 2 people - display also quantity of a given food).
  - Should lead to a form that allows users to add new food.
- Recipes list:
  - Should display a list of recipes created by the logged-in user as in the wireframe.
  - Should lead to recipe details.
  - If the user is the owner of the recipe, should allow the user to delete it.
- Public recipe list:
  - Should display a list of all public recipes ordered by newest as in the wireframe.
  - Should lead to recipe details.
- Recipe details:
  - If the recipe is public or the user is the owner of the recipe, should display the recipe details as in the wireframe.
  - If the user is the owner of the recipe, should lead to the form that allows the user to add new food.
- General shopping list view (only for a group that has less than 3 members):
  - Should show the list of food that is missing for all recipes of the logged-in user (compare the list of food for all recipes with the general food list of that user).
  - Should count the total food items and total price of the missing food.
- Make sure there are no N+1 queries happening.
- Create a navigation menu that allows users to open all of the pages you created.

Feature/project setup

Add Feature/recipe details

Feature/shopping list

Add documentation

Felix45

Hi @amon-cofie & @RichardChileya ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights ✔️

No linter errors ✅
Students solved N+1 queries problem ✅
Descriptive pull request title and summary ✅
Git flow is used correctly ✅

Required Changes ♻️

Check the comments under the review.

Optional suggestions

[ Required ] I've noticed that the license link on your readme file is not working, it leads to a 404 page not found error. I would like to suggest that you fix this by adding License file in your root directory and provide a link to the license on the readme file. You can use the contents of the MIT license on this link Click Here >>

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

app/views/foods/index.html.erb

app/views/recipes/show.html.erb

app/views/recipe_foods/new.html.erb

test/models/recipe_food_test.rb

config/routes.rb

app/controllers/application_controller.rb

Add testing

Feature/review project

codepantha

STATUS: CHANGES REQUIRED ♻️ 📌

Hi team 👋,

Great work on making the changes requested by the previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights 🎯

✔️ Descriptive PR
✔️ Used GitFlow correctly
✔️ No linter errors

Required Changes ♻️

Check the comments under the review.

You have done well writing some tests for your application 👏 Please write tests for the models as well 😎

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

codepantha · 2023-02-18T15:30:27Z

README.md

+## 📝 License <a name="license"></a>
+
+This project is [MIT](https://choosealicense.com/licenses/mit/) licensed.


[OPTIONAL] In order to have a license file for your project, you need to create a file called LICENSE in the root of your project, edit it with the correct information, then link it like this 👇

This project is [MIT](./LICENSE) licensed.

codepantha · 2023-02-18T15:55:38Z

app/controllers/shopping_lists_controller.rb

+  def index
+    @all_ingredients = RecipeFood.includes(:recipe, :food)
+    @missing = @all_ingredients.select { |ing| ing.quantity > ing.foods.quantity }
+    @missing_ingredients = @missing.map do |ingredient|
+      {
+        name: ingredient.foods.name,
+        quantity: ingredient.quantity - ingredient.foods.quantity,
+        price: ingredient.foods.price * (ingredient.quantity - ingredient.foods.quantity)
+      }
+    end
+    @total_price = @missing_ingredients.map { |ing| ing[:price] }.sum
+  end


An error occurs while trying to generate the shopping list. Please see error screenshot below and try to fix it 👍

codepantha · 2023-02-18T16:02:09Z

app/views/recipe_foods/new.html.erb

+ <%= form_with model: @recipe_new, url: recipe_recipe_foods_path do |f| %>
+  <div class="form_control">
+      <%= f.label :quantity %>
+      <%= f.number_field :quantity %>
+    </div>
+
+    <div class="form_control">
+    <%= f.select(:food_id, @foods.map{|u| [u.name, u.id]}) %>
+    </div>
+
+    <div class="form_control">
+    <%= f.hidden_field :recipe_id, value: @recipe_new.recipe_id %>
+    </div>
+    <%= f.submit "Submit", class:"btn btn-success" %>
+<% end%>


Just like the previous reviewer observed and advised, only authorized users (owner of the recipe) should be able to add a new food to the recipe as stated in the project requirements below 👇

codepantha · 2023-02-18T16:05:37Z

app/controllers/application_controller.rb

+
+  def configure_permitted_parameters
+    devise_parameter_sanitizer.permit(:sign_up, keys: %i[name email password])
+    # devise_parameter_sanitizer.permit(:account_update, keys: %i[name email password photo bio])


Just as the previous reviewer recommended, please remove commented code in order to have a cleaner and less cluttered code base 👍

Feature/review project

prolajumokeoni

Hi @Team

Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉

Highlights

All changes requested have been implemented 🚀

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

amon-cofie and others added 30 commits February 13, 2023 13:50

Create the database

d5ef0fe

Add migration files and create database schema

41c1ce9

fix linters error

12ae02f

Add linters

bb4cb87

fix linters

00ddbab

Add gem files

74d3a0d

Add ruby linters checker

f67a9da

Add package files

9790f0c

Add draft test files

b7855b0

Add yml files

f98f233

Add user model

ed802cd

Add recipe model

1d6a578

Add recipe food model

33fbb18

Add food model

85509e4

Update git ignore (database yml ignore)

7b2315e

Merge pull request #13 from amon-cofie/feature/project_setup

41b442c

Feature/project setup

Update routes.rb

c1518ae

Add foods controller

7e473e1

Add public recipes controller

d458f39

Add recipe foods controller

80a8753

Add recipes controller

a73e695

Add shopping lists controller

423a4d8

Add users controller

203f2b6

Update recipe_foods model

a292b6f

fix linter errors

eb55db5

Fix linter errors

46fc040

Fix linters

881e918

Fix linter errors

1fd1428

Fix linter errors

87d6cad

Fix linter errors

b2125c3

RichardChileya and others added 15 commits February 18, 2023 00:44

Add Ingridients table

524d235

Add recipe show page

135fc48

Update recipe_food model

e3dc5a8

Update recipe_foods controller

f9d5960

Update recipe_foods controller

ae30694

Add styles

b82c726

fix linters

c7ad794

Modify public recipes index page

c1482ce

Add styling to public recipes page

ae28d70

Fix linter issues

09f734a

Fix stylelint errors

e63c733

Merge pull request #21 from amon-cofie/feature/recipe_details

418dd4d

Add Feature/recipe details

Merge pull request #22 from amon-cofie/feature/shopping_list

0cb288d

Feature/shopping list

Add documentation

bd8168a

Merge pull request #23 from amon-cofie/documentation

0016150

Add documentation

Felix45 suggested changes Feb 18, 2023

View reviewed changes

amon-cofie and others added 9 commits February 18, 2023 14:48

Add testing for controllers

1b90c6d

remove commented code

728e7bb

Merge pull request #25 from amon-cofie/testing

1a919fa

Add testing

Fix styling

ce06973

Add delete button to foods table

d818188

fix authentication

c6fcb3b

Update styling

8627c38

Merge pull request #26 from amon-cofie/feature/review_project

b2171a2

Feature/review project

fix buttpn error

ed919dd

codepantha suggested changes Feb 18, 2023

View reviewed changes

amon-cofie added 2 commits February 18, 2023 19:47

Fix problems pointed out by reviewer

c1c7160

Merge pull request #27 from amon-cofie/feature/review_project

388f2f3

Feature/review project

prolajumokeoni approved these changes Feb 18, 2023

View reviewed changes

Add DB

0c84942

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DavRich-Recipe-App working prototype #24

DavRich-Recipe-App working prototype #24

amon-cofie commented Feb 18, 2023

Felix45 left a comment

codepantha left a comment

codepantha Feb 18, 2023

codepantha Feb 18, 2023

codepantha Feb 18, 2023

codepantha Feb 18, 2023

prolajumokeoni left a comment

		## 📝 License <a name="license"></a>

		This project is [MIT](https://choosealicense.com/licenses/mit/) licensed.

DavRich-Recipe-App working prototype #24

Are you sure you want to change the base?

DavRich-Recipe-App working prototype #24

Conversation

amon-cofie commented Feb 18, 2023

Felix45 left a comment

Choose a reason for hiding this comment

Highlights ✔️

Required Changes ♻️

Optional suggestions

codepantha left a comment

Choose a reason for hiding this comment

STATUS: CHANGES REQUIRED ♻️ 📌

Hi team 👋,

Highlights 🎯

Required Changes ♻️

Optional suggestions

codepantha Feb 18, 2023

Choose a reason for hiding this comment

codepantha Feb 18, 2023

Choose a reason for hiding this comment

codepantha Feb 18, 2023

Choose a reason for hiding this comment

codepantha Feb 18, 2023

Choose a reason for hiding this comment

prolajumokeoni left a comment

Choose a reason for hiding this comment

Highlights

Optional suggestions