POC: use of adb_client in xtask/daemon.rs #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr-Kanister
changed the title
|
State:
|
Closed
Signed-off-by: Mr-Kanister <[email protected]>
The commit implements both a server and a client process communicating over stdin and stdout.
Adb is the established way of launching and controlling processes on an android machine.
Stdin and Stdout is chosen, because thats the way to communicate over an adb shell.
The server process on android is started with a json request that specifies what process it should run:
```json
{
"command": "/data/local/tmp/backend-daemon",
"args": [],
"env": { "RUST_LOG": "trace" },
"root": true
}
```
It sends the logs over stdout in the following format:
{
"Stdin": "...",
"Stderr": "...",
"InternalError": "..."
}
The server exits when the process stops, or when the client on the host sends `"Exit"` over stdin.
The client/host process requires a specification in the following format:
```json
{
"runner_path": "./target/x86_64-android-linux/release/runner-server",
"args": [],
"env": { "RUST_LOG": "trace" },
"root": true
}
Also, it takes a path to the executable as last argument, to be compatible with `cargo run` and `cargo test`.
The client connects to the android device via adb, pushes the executable and the server.
Afterwards it executes the server over adb with the appropriate request.
Signed-off-by: Felix Hilgers <[email protected]>
Signed-off-by: Felix Hilgers <[email protected]>
Signed-off-by: Felix Hilgers <[email protected]>
fhilgers
force-pushed
the
166-adb-push
branch
from
a5f8261 to
896a97f
Compare
Signed-off-by: Felix Hilgers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regards #166.
The goal of the issue is to replace the current Python script for pushing and running the binaries on the emulator with a more robust Rust implementation.
My current knowledge is not sufficient to continue working on the task, so for now it remains a proof of concept.
With the current changes, the daemon gets pushed and ran on the client via the newly added crate
adb_client. I have encountered several problems:adb_client::ADBServerDevice::shell_commandblocks until the respective shell command is finished. This means that background execution of the daemon is only possible via thread. However, standard threads are difficult to terminate,pkillis suboptimal.An alternative is
adb_client::ADBServerDevice::shell, this gets a reader and a writer, which could then be used to terminate the daemon. However, I do not (yet) know how to use it.Another possibility might be to create a grpc endpoint which can send a death pill to the daemon and thus terminate it cleanly.
There is also another crate that might be interesting: https://docs.rs/adb-client-tokio/latest/adb_client_tokio/
Usage
cargo xtask integration-test: broken because of issues abovecargo xtask daemon --android: working without background flag.cargo xtask daemon: starting, but daemon not killed after pressing Ctrl+C.cargo xtask client: Unchanged.Thanks @fhilgers for the many attempts to help.