Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'data' is not defined when using REST Input #225

Open
RicePatrick opened this issue Jan 15, 2025 · 2 comments
Open

'data' is not defined when using REST Input #225

RicePatrick opened this issue Jan 15, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@RicePatrick
Copy link

RicePatrick commented Jan 15, 2025

When creating a new pipeline using the REST Input stage, attempting to run the pipeline or use the generated python code results in a 'data' is not defined error.

This appears to be a result of the fact that the data frame that's established uses a hardcoded variable name instead of the ${outputName}_data that is actually initialized by reading in the json.

I believe that the bug is present in both if blocks here: https://github.com/amphi-ai/amphi-etl/blob/main/jupyterlab-amphi/packages/pipeline-components-core/src/components/inputs/cloud/RestInput.tsx#L72

Steps to reproduce:

  • Spin up a new Jupyterlabs docker image and install amphi
  • Create a new pipeline
  • Add a Rest Input step, and add any REST URL as the URL
  • Run pipeline
@tgourdel tgourdel added the bug Something isn't working label Jan 17, 2025
@gogi2811
Copy link

gogi2811 commented Jan 20, 2025

I am taking up the issue.

@tgourdel
Copy link
Contributor

Thanks for reporting @RicePatrick and looking into the issue. Good catch. Will address it shortly

gogi2811 pushed a commit to gogi2811/amphi-etl that referenced this issue Jan 21, 2025
tgourdel added a commit that referenced this issue Jan 24, 2025
fixed Bug #225 'data' is not defined when using REST Input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants