fix(lint): Do not directly call object builtins #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-lu
commented
Jan 12, 2021
| @@ -1140,7 +1140,7 @@ AmplitudeClient.prototype.identify = function (identify_obj, opt_callback) { | |||
| } | |||
|
|
|||
| // if identify input is a proxied object created by the async loading snippet, convert it into an identify object | |||
| if (type(identify_obj) === 'object' && identify_obj.hasOwnProperty('_q')) { | |||
| if (Object.prototype.hasOwnProperty.call(identify_obj, '_q')) { | |||
There was a problem hiding this comment.
trying to call this on a non-object-like will fail, so I got to remove a check here :)
haoliu-amp
approved these changes
Jan 12, 2021
kelsonpw
approved these changes
Jan 12, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 11, 2021
## [7.4.2](v7.4.1...v7.4.2) (2021-02-11) ### Bug Fixes * **lint:** Do not directly call object builtins ([#344](#344)) ([14fc693](14fc693))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are heavy users of the Object prototype
hasOwnProperty. In general, these should not be called directly - especially on user-created inputs. Allows a lint override to be removed.Did not add it to the
tests/browsersdir because I'm not linting sinon or chai 🤷Checklist