Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(identify): add preInsert, postInsert, remove to Identify and gro… #372

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

yuhao900914
Copy link
Contributor

@yuhao900914 yuhao900914 commented Mar 17, 2021

…upIdentify

Summary

Implement preInsert, postInsert, remove for identify and identify group.
Add the unit test for testing the new functions.

Checklist

  • Does your PR title have the correct title format? Yes
  • Does your PR have a breaking change?: No

Copy link
Contributor

@kelvin-lu kelvin-lu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good. some consistency changes with the docs

src/identify.js Outdated Show resolved Hide resolved
@yuhao900914 yuhao900914 merged commit 7e9e992 into main Mar 18, 2021
@yuhao900914 yuhao900914 deleted the identifyFunctions branch March 18, 2021 04:02
github-actions bot pushed a commit that referenced this pull request Mar 19, 2021
# [8.1.0](v8.0.0...v8.1.0) (2021-03-19)

### Features

* **identify:** add preInsert, postInsert, remove to Identify and gro… ([#372](#372)) ([7e9e992](7e9e992))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants