feat: update setLibrary api make it ignore the null value of name or version #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao900914
changed the title
qingzhuozhen
approved these changes
Nov 17, 2021
src/amplitude-client.js
Outdated
| ) { | ||
| this.options.library = { name: name, version: version }; | ||
| AmplitudeClient.prototype.setLibrary = function setLibrary(name, version) { | ||
| if (name) this.options.library.name = name; |
There was a problem hiding this comment.
nit: maybe wrap other than put them in the same line
jooohhn
suggested changes
Nov 17, 2021
src/amplitude-client.js
Outdated
| this.options.library = { name: name, version: version }; | ||
| AmplitudeClient.prototype.setLibrary = function setLibrary(name, version) { | ||
| if (name) this.options.library.name = name; | ||
| if (version) this.options.library.version = version; |
There was a problem hiding this comment.
I think we should do an explicit check for null or undefined. Edge case conditions for falsey values may lead to unexpected outcomes (ike 0 or '' )
| @@ -1114,7 +1114,7 @@ var _convertProxyObjectToRealObject = function _convertProxyObjectToRealObject(i | |||
| * var identify = new amplitude.Identify().set('colors', ['rose', 'gold']).add('karma', 1).setOnce('sign_up_date', '2016-03-31'); | |||
| * amplitude.identify(identify); | |||
| */ | |||
| AmplitudeClient.prototype.identify = function (identify_obj, opt_callback, opt_error_callback) { | |||
| AmplitudeClient.prototype.identify = function (identify_obj, opt_callback, opt_error_callback, outOfSession) { | |||
There was a problem hiding this comment.
May be good to add unit test for out of session funcitonality
jooohhn
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist