Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-web-push support #6453

Closed
rgomezp opened this issue Jul 12, 2021 · 3 comments
Closed

amp-web-push support #6453

rgomezp opened this issue Jul 12, 2021 · 3 comments
Labels
Support Help with setup, implementation, or "How do I?" questions.

Comments

@rgomezp
Copy link

rgomezp commented Jul 12, 2021

Feature description

Currently there is no easy way that I know of to integrate push notifications with the official AMP plugin for Wordpress. Setting up notifications requires writing some custom markup (adding the amp-web-push tag with configuration properties) that doesn't get removed by the plugin automatically (perhaps you could whitelist amp HTML tags to prevent removal). The plugin doesn't provide a way to add custom code whatsoever (see support ticket: https://wordpress.org/support/topic/how-can-i-add-custom-html-in-page/).

Workaround:
The workaround currently is to add the markup via atomic blocks in each individual page or post. However, this is not optimal.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation brief

QA testing instructions

Demo

Changelog entry

@rgomezp rgomezp added the Enhancement New feature or improvement of an existing one label Jul 12, 2021
@milindmore22
Copy link
Collaborator

Hello @rgomezp

I created a mini plugin to make OneSignal – Web Push Notifications AMP Compatible, we prompt using it to whoever asks for it in AMP Support Forums.

@rgomezp
Copy link
Author

rgomezp commented Jul 13, 2021

@milindmore22 ,
And this works with the official AMP plugin?

Are there any plans to integrate it into the official AMP plugin?

@milindmore22
Copy link
Collaborator

milindmore22 commented Jul 14, 2021

@rgomezp
yes, this works with the official AMP plugin, The AMP plugin allows users to serve AMP pages, it is not purposed to serve push notifications. so it will best approach that AMP Compatability gets adopted in the OneSignal WordPress plugin.

I will try to contribute to the OneSignal WordPress plugin to make it AMP Compatible.

@westonruter westonruter added Support Help with setup, implementation, or "How do I?" questions. and removed Enhancement New feature or improvement of an existing one labels Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Support Help with setup, implementation, or "How do I?" questions.
Projects
None yet
Development

No branches or pull requests

3 participants