Added AMP Support #276
Merged
Added AMP Support #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rgomezp any updates on this PR? |
rgomezp
suggested changes
Feb 22, 2022
There was a problem hiding this comment.
Howdy @milindmore22 ,
Thanks for your PR and also your patience!
This PR looks great, just left a couple nits for you. Let's get this merged!
Thanks so much again.
|
@rgomezp Addressed PR feedback |
rgomezp
approved these changes
Feb 25, 2022
jkasten2
reviewed
Feb 25, 2022
There was a problem hiding this comment.
PR looks good to me
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AMP Compatability
This change is