Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP Stories] Hide all block insertion points #2054

Merged
merged 2 commits into from
Apr 3, 2019

Conversation

swissspidy
Copy link
Collaborator

Prevents all these inserters before/after a block from showing up.

Does not address the inserter visibility on the right side of the page, as this is more related to #1966.

Fixes #2047.

@swissspidy swissspidy requested review from amedina and miina April 3, 2019 14:33
@googlebot googlebot added the cla: yes Signed the Google CLA label Apr 3, 2019
@miina
Copy link
Contributor

miina commented Apr 3, 2019

I'm still seeing the inserter for some reason.

Screen Shot 2019-04-03 at 6 20 14 PM
Screen Shot 2019-04-03 at 6 20 03 PM

@swissspidy swissspidy changed the title Hide all block insertion points [AMP Stories] Hide all block insertion points Apr 3, 2019
@swissspidy
Copy link
Collaborator Author

@miina Thanks, should be fixed now with the latest commit!

I was only hiding the inserters (which are shown before a block, I think) but not the appenders (which are shown after a block, I think).

Copy link
Contributor

@miina miina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@swissspidy swissspidy merged commit 83ed44d into amp-stories-redux Apr 3, 2019
@swissspidy swissspidy deleted the amp-story/2047-inserters branch April 3, 2019 17:07
@westonruter westonruter added this to the v1.2 milestone May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants