Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse 'data-set-focus' to simulate twentytwenty keyboard focus #3621

Merged

Conversation

schlessera
Copy link
Collaborator

@schlessera schlessera commented Oct 25, 2019

Summary

Changes the toggle emulation logic to reuse TwentyTwenty's data-set-focus attribute and manually set keyboard focus when triggering a toggle.

This ensures we correctly set keyboard focus on the Close button when opening the menu modal.

Screen Recording 2019-10-25 at 06 58 AM

Fixes #3618

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@schlessera schlessera added Bug Something isn't working Sanitizers labels Oct 25, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 25, 2019
@westonruter westonruter added this to the v1.4 milestone Oct 25, 2019
@westonruter
Copy link
Member

Nice work.

@westonruter westonruter merged commit f893db3 into develop Oct 25, 2019
@westonruter westonruter deleted the fix/3616-set-focus-on-close-button-when-opening-menu branch October 25, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working cla: yes Signed the Google CLA Sanitizers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TwentyTwenty: keyboard focus not set on Close button in main menu
3 participants