Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skip-link-focus-fix in Twenty Twenty #3665

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Oct 29, 2019

Summary

WordPress 5.3-RC3 introduced a regression on Twenty Twenty's AMP-compatibility by adding the skip-link-focus-fix: WordPress/twentytwenty#937 (r46613). This PR ensures that that the script gets removed since it is not needed, as done with the other core themes, as the AMP framework internalizes the fix.

See #3342.

Before

Screen Shot 2019-10-29 at 15 53 35

After

Screen Shot 2019-10-29 at 15 53 50

Checklist

  • My pull request is addressing an open issue (please create one otherwise).
  • My code is tested and passes existing tests.
  • My code follows the Engineering Guidelines (updates are often made to the guidelines, check it out periodically).

@westonruter westonruter added this to the v1.4 milestone Oct 29, 2019
@googlebot googlebot added the cla: yes Signed the Google CLA label Oct 29, 2019
@westonruter westonruter merged commit a84a21d into develop Oct 29, 2019
@westonruter westonruter deleted the fix/twentytwenty-skip-link-focus-fix branch October 29, 2019 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Signed the Google CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants