Prevent wpautop() from modifying Twitter embed
#3874
Conversation
|
Oh, I see. This now brings to mind an issue we had with placeholder content in This being the case, I am wary of modifying the behavior of |
|
Just wanted to point out that dynamic blocks are rendered by preventing |
pierlon
changed the title
wpautop() last on post contentwpautop() from modifying Twitter embed
pierlon
force-pushed
the
fix/3865-duplicate-twitter-embed
branch
from
0ef896f to
118facf
Compare
|
Rebased to remove the commit messing with |
|
Yes that makes sense. |
| } | ||
| $content = AMP_DOM_Utils::get_content_from_dom( $dom ); | ||
|
|
||
| $this->assertEquals( $content, $expected ); |
There was a problem hiding this comment.
@pierlon For PHPUnit assertion, the expected value always comes first, followed by the actual value.
This is important because PHPUnit will tell you what it expected, and what it got instead. If you put the values in the wrong order (like here), this is misleading and causes you to look in the wrong places.
I'm rectifying this in #3758, as I'm touching those tests anyway.
There was a problem hiding this comment.
Ah thanks for pointing that out, noted 👍 .
Summary
The cause of the duplication was due to
wpautop()mucking with the content, wrapping tags it deems as "block-level" with a<p>which causes theblockquotetag to be placed outside the AMP component. Once outside, theblockquoteis santitized as a raw embed and another Twitter AMP component would be rendered.Removing the HTML oEmbed filter in
AMP_Twitter_Embed_Handlerwill allow forwpautopto process the original HTML, and allows the raw embed sanitizer within the class to convert it into an AMP component, without any interference.Fixes #3865.
Checklist