Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete yarn.lock and update package-lock.json #11302

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Delete yarn.lock and update package-lock.json #11302

merged 2 commits into from
Sep 15, 2017

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Sep 15, 2017

Cleans up the bad merge described in #9775 (comment)

Follow up to #11279
Fixes #11278

@rsimha
Copy link
Contributor Author

rsimha commented Sep 15, 2017

/to @erwinmombay @danielrozenberg

@dreamofabear
Copy link

Does package-lock.json need to be updated? The Babel 6 upgrade modified package.json.

@rsimha
Copy link
Contributor Author

rsimha commented Sep 15, 2017

@choumx Good point, but there were no changes when I blew away my node_modules directory and re-ran npm prune && npm install on my machine.

The documentation at https://docs.npmjs.com/files/package-lock.json says that the files would be changed if necessary, but I'm somehow not convinced. @erwinmombay @danielrozenberg Is this weird? Can one or both of you test this on your machines to make sure we're okay?

@rsimha
Copy link
Contributor Author

rsimha commented Sep 15, 2017

@choumx Scratch my earlier comment. I had an older version of npm on my machine (the one that comes with node 4 by default), and it's all good once I upgraded.

I'll update the instructions if necessary.

@rsimha rsimha changed the title Delete yarn.lock Delete yarn.lock and update package-lock.json Sep 15, 2017
@rsimha
Copy link
Contributor Author

rsimha commented Sep 15, 2017

Can confirm that yarn is no longer run on Travis, and that npm install (with the correct version of npm) takes ~16 s on Travis.

Will merge this once tests are green.

@rsimha rsimha merged commit 7a0413c into ampproject:master Sep 15, 2017
@rsimha rsimha deleted the 2017-09-15-Yarn branch September 15, 2017 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants