-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update links that were pointing to the master
branch of amp-github-apps
#33571
📖 Update links that were pointing to the master
branch of amp-github-apps
#33571
Conversation
Hey @erwinmombay! These files were changed:
Hey @jridgewell! These files were changed:
Hey @alanorozco! These files were changed:
Hey @estherkim! These files were changed:
Hey @danielrozenberg! These files were changed:
Hey @Jiaming-X! These files were changed:
Hey @jeffkaufman! These files were changed:
Hey @gmajoulet! These files were changed:
Hey @mszylkowski! These files were changed:
Hey @processprocess! These files were changed:
Hey @t0mg! These files were changed:
Hey @newmuis! These files were changed:
Hey @Enriqe! These files were changed:
Hey @wassgha! These files were changed:
Hey @ampproject/wg-caching! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking comment per @rsimha's request
Update: ampproject/amp-github-apps#1256 has been merged, and the default branch of This PR can be merged now. @jridgewell @kristoferbaxter Could I get a top-level owners approval from one of you? And @danielrozenberg, could I get an Infra-team approval from you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:rubber-stamp:
The branch has been renamed, and this PR is now safe to merge.
This PR updates all links in
amphtml
documentation that were pointing to themaster
branch of theamp-github-apps
repo to usemain
instead. It can be merged at leisure after the branch is renamed (see this plan), because GitHub links are auto-redirected.Sending this out for review and owners approval. On self-review, this PR changes only the documentation comments in our
OWNERS
files, so it should be fairly safe to merge after the branch rename. (Won't merge until after the rename is complete.)Partial fix for #32195