date mm parser expects zero based months

[groner]

I'm not sure if this was intended, but it would be nice if it could work with iso8601 dates.

Running this:

picker = jQuery($0).data('pickadate');
picker.set('select', '2013-01-01', {format: 'yyyy-mm-dd'});
picker.get();

Yields this:

"1 February, 2013"

But I expected this:

"1 January, 2013"

Thanks!

[amsul]

Although undocumented, you can already do this. It’s used internally to parse the data-value attribute by passing a truth-y data option:

picker = jQuery($0).data('pickadate');
picker.set('select', '2013-01-01', {format: 'yyyy-mm-dd', data: true});
picker.get();

This should parse as the expected date.

I’ll leave this issue open till I update the docs.

Cheers!

[groner]

I did come across that code, but it seemed like an internal detail I shouldn't rely on.

I am curious though, is there something that uses zero based months in formatted strings?

[amsul]

Do you mean to ask if there is any case where the zero-based months are used to generate a string value of the date?

The zero-based months are mostly to keep inline with what people expect from native Date objects. It’s also much easier to deal with zero-based months when you have an array of month names that starts with 0 as the index.

[amsul]

Oh and yes, it is for internal use - but I wont be changing it so I guess it's safe to use.

[boxofrad]

Hey @amsul,
Other than ease of implementation is there a design reason you opted for zero based months?
As @groner mentioned it makes it quite irritating when using ISO 8601 formatted dates, and also behaves differently to JavaScript's native date parsing.

new Date('2013-01-01') // Tue Jan 01 2013 00:00:00 GMT+0000 (GMT)

Perhaps an alternative would be to give a format string of "iso8601" that adheres to the standard instead, like so:

picker.set('select', '2013-01-01', { format: 'iso8601' });

Would you accept a pull request adding this?

[amsul]

@boxofrad yup, that’s right. The native date parser does work that way.

Rather than the need to pass iso8601, I believe the parser should be fixed. It should check for the value as a string and compensate for the month’s index. This will be fixed in the next release.

Cheers!

[GoZOo]

e4c91cc commit fix this. Whithout @denis-sokolov commit, default input value like 2014-03-24 show wrong month in calendar (April).