Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean build artifacts from the repository #360

Closed
denis-sokolov opened this issue Mar 5, 2014 · 3 comments
Closed

Clean build artifacts from the repository #360

denis-sokolov opened this issue Mar 5, 2014 · 3 comments
Labels
Milestone

Comments

@denis-sokolov
Copy link
Contributor

I see that you have a complicated and serious build process for your library, thus you may have perfect reasoning for what you have.

As a small-time contributor I shall note that it's off-putting that every time I run grunt a bajilion of git-tracked files are suddenly modified. It makes it hard to see what's happening and what I should commit.

In particular, api.htm has timestamp and timezone changes on build.
lib/picker.js gets a changed timestamp.
There are also three copies of every file. _raw, normal, and compressed.
It's all a bit daunting, if it was possible to simplify some of that, it'd help other contributors. (I'm used to it by now).

@amsul
Copy link
Owner

amsul commented Mar 5, 2014

Yeah I completely agree. It’s something I’ve wanted to clean up for a long time but haven’t come around to as it was low priority.

I’ll try to make it simpler when I start working on v3.4.1

@amsul amsul added the todo label Mar 5, 2014
@amsul amsul added this to the v3.4.1 milestone Mar 5, 2014
@denis-sokolov
Copy link
Contributor Author

Cool, thanks for replying. Feel free to close this issue, if you want, of course.

@amsul
Copy link
Owner

amsul commented Mar 5, 2014

Nah, I’ll forget :p

amsul added a commit that referenced this issue Apr 12, 2014
@amsul amsul added solved and removed todo labels Apr 12, 2014
@amsul amsul closed this as completed in 9e22bcf Apr 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants