Wrong date being selected

[leads]

Hi. I raised a bug on an Angular directive using this plugin. However I don't think it's an Angular thing, I think there is a bug with the latest version.

I downloaded the zip from GIthub and ran both index.htm and date.htm.

I think it's an issue when selecting an older date or a date several months in the future.

Select a date in the past, say 7th October 2014, and it selects October 8th (says so in the and highlights the 8th when reopening the calendar). Tested in both Chrome and Firefox on Mac.

Anyone else getting this issue?

[johanhelsing]

I have the opposite issue, actually. If I select the date programmatically, the wrong date will be highlighted.

var datepicker = $("#datepicker").pickadate('picker');
datepicker.set('select', new Date(2012, 0, 12);
datepicker.render(true);

When I open the datepicker afterwards, 11 January 2012 will be highlighted, instead of 12 January as expected.

EDIT:

It seems pickadate expects a date in utc format. I was able to create a workaround for my issue like this:

function localToUTCDate(date) {
    return date ? new Date(Date.UTC(
        date.getFullYear(),
        date.getMonth(),
        date.getDate()
    )) : undefined;
}
var datepicker = $("#datepicker").pickadate('picker');
datepicker.set('select', localToUTCDate(new Date(2012, 0, 12));
datepicker.render(true);

[ajmueller]

I am seeing a similar issue that I detailed in #567. "Today" is sometimes highlighting as tomorrow. I wonder if it has to do with time zone calculations as I'm in GMT-0800 and I only noticed this today after 4pm.

[amsul]

Yeah, this was a pretty nasty regression introduced in v3.5.4. I've downgraded the gh-pages branch to v3.5.3 - which was the last release before the UTC changes were added.

The UTC problems are no longer an issue in v4 (#446). So instead, I'll be putting my focus on getting that out faster.

If someone wants to tackle UTC in v3, I would definitely accept a PR.

[amsul]

At this point, the best solution would be to stick with v3.5.3.

[ajmueller]

Does 3.5.3 have iOS 8 issues? If so, I'd potentially be willing to take a look at the UTC issues in v3 since I'm using this for a major project that will be launching in a few months.

Any idea on the v4 timeline?

[amsul]

Yes, I believe so. But I'd like to selectively merge in the commits that resolved those issues without the ones that introduced the UTC bug.

Looking at the changelog now, I think even 3.5.3 has the UTC issue. So 3.5.2 should be the safest choice.

In regards to v4, cannot make any promises, but I would like to have a beta out by the new year.

[marr1977]

Hi,
regarding #570, it would be nice if the widget is time zone aware. Take the 'max' and 'min' properties for example. It's possible to set a Date object for these attributes in which case we see that pickadate interprets these as being the computer local time zone. But if would be nice to be able to set a different time zone.

Or when you call get('select') on the pickadate widget, you will get an object which, among other things, contains a Date object that corresponds to the selected date in the current time zone.

[Dayjo]

Hi Guys, love the date picker, by far the best one I've found so far.

This issue makes me sad, just discovered it in my implementation.

Is the only way to fix this at the moment using 3.5.2?

Thanks for your hard work, I hope I can contribute somehow (maybe not UTC handling just yet ;))

[Dayjo]

Also, @amsul is this issue really closed? I think it's worth keeping it open until there's a solution so that it stops being raised?

[amsul]

I’ve pushed the fix to the master branch: https://github.com/amsul/pickadate.js/tree/master

Can someone please verify it works for them as well?

[ajmueller]

I have a reminder to test this at 4pm my time today since, as I noted above, this appears to be timezone dependent. I'll let you know the outcome.

[ajmueller]

Validated that the issue is gone on master. I suppose next time I could just manually update my system clock instead of waiting...oh well. This gave me a simple thing to do at the end of my day.

Thanks for the fix. I'm using your plugin in a very large project and the functionality of having a date picker is vital.

[luisrudge]

any ETA on the next release?

[amsul]

Hoping to have it out by next week. Just need to make sure all the iOS8 issues have been resolved ( #523 ). People with iPhones, I'd appreciate any verification :)

[cmwelsh]

This makes the current version totally useless... push out a new release... 👍

[amsul]

This is fixed on master - feel free to point to there with Bower (or whatever your tool of choice).

3.5.5 will be tagged when the remaining issues are resolved: https://github.com/amsul/pickadate.js/milestones/3.5.5

Cheers.