-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Picker doesn't open on iOS 8 #523
Comments
An update to this - the 'classic' theme works ok. |
default theme : classic theme : |
I also confirm the issue, iOS8 with an iPhone 5C |
Had brief access to a Yosemite beta machine which allowed me to inspect a page in Safari via the iOS 8 Simulator. Couldn't see what the obvious issue was/is. I thought it would be CSS only but perhaps not. Important to note that when the calendar is open, if you hit the 'Done' button (bottom bar, an iOS control) it seems to reset the form to the correct place. So perhaps something is happening to the DOM to effect position: fixed? |
A blur() on the input element after opening the picker, fixed it for me! |
Can you share your code fix please? Just tried a blur event and there is no fix in the iOS simulator. Thank you. |
with jquery, .blur (); on input element on close event fixed the problem |
@nicolomonili and @waquner are you able to share your code fix please? |
|
Ok, thank you. Why/how does this work with the onClose event, when the issue is with it opening? Anyway, I'll try it now. |
I had this problem: after the onClose event, the input remained with the focus, then I put the .blur () on onClose event |
Ok, so did you have the issues of the calendar not showing correctly? |
in this issue (#523) 2 problem have been reported 1 : calendar not showing correctly (I also still have this problem, for now I use the classic theme) |
Thank you for the clarification. |
For me, problem 1 (calendar not showing correctly) was also fixed by blur(), but onOpen:
|
Thank you. Unfortunately that does not work in my situation, at least not on the iOS 8 simulator. |
With the 'classic' theme, once you have selected a date, you can't then re-open the calendar. Also, I am using the .on('close') function, rather than the 'onClose' function. 'onClose' screwed with my date format. $('.myinput').on('close', function(event) {
$('.myinput').blur();
}); |
Having the same issue with the default theme on iOS 8. The element.blur() call did not resolve the issue. Tried adding it in both listeners (onClose, onOpen). I noticed that toggling (first setting it to relative and then to fixed) the position:fixed of the .picker container in the onOpen listener fixed the issue. There is something wrong with the position:fixed support in iOS 8. |
Same issues still happening in 8.0.2. |
I've fixed it locally - will have it on the dev branch soon! |
Pushed a fix to the If anyone can test and verify it works for them as well, I’d appreciate it. There will be a tagged release soon. |
Tested successfully on iOS 8.1.1 on both iPad and iPhone. Tag 3.5.4 has the issue and current master does not. EDIT: While the issue of the picker never opening properly in iOS 8 is fixed on master, #559 appears to still potentially be an issue. On iPhone in portrait mode after selecting dates for one input two or three times in a row, it can take multiple taps on the input to re-open the picker. Strangely I do not have this issue in landscape mode on iPhone or in either orientation on iPad. I am using an iPhone 6 and iPad Air 2. |
Further to this issue, I'm noticing something strange on iOS8 (iOS simulator at this stage) with the master branch (using default style). When I open the datepicker it now initially displays correctly, however if I attempt to select a month or year from the drop down lists (I'm using selectYears and selectMonths) the datePicker flies to the bottom of the page and leaves the user there? |
Got the same issue here. Also if you try to navigate through the months replicate the same behaviour of |
|
@timcreatewell, @izifortune I believe that's related to #609. As long as the picker opens, I believe this issue has been resolved... |
Hi. Great work on reduced this to a fix. The CHANGELOG.md file states that this has been fixed in 3.5.5, but this version has not been tagged or published. Does it look like 3.5.5 will be released soon? Or is it waiting for other work to be completed? |
@jokeyrhyme the remaining issues for the 3.5.5 milestone: https://github.com/amsul/pickadate.js/milestones/3.5.5 Cheers. |
Hi there @amsul, thanks so much for releasing 3.5.5! I updated my project with the new files this morning but unfortunately (on the iOS simulator at least - iOS 8.1) I'm still seeing the same behaviour: when you choose a year/month from the drop downs (selectYears / selectMonths) the picker (using default style) still scoots to the bottom of the screen. Or could I be missing something? |
@timcreatewell I'm not sure if this is what you're experiencing, but I have noticed there are still a few layout issues with v3.5.5 on iOS. I've made an unlisted YouTube video here: http://youtu.be/2-Ha45DP2gw |
I confirm I have the same issue. Ipad 3 IOS 8.2 datepicker not opening at all it opens just sometimes randomply. android all ok. I tried also the master and also the blur fix but nothing changed. |
Hi @amsul, it looks like this thing was never actually fixed. This solution still seems to work on v3.5.6 as well. Not sure what the solution is here but for now I'm still just commenting out those lines. |
On iPad Mini with iOS 8.0.2 using v3.5.6, I still got this issue when I try to change date. |
@riccardobevilacqua is the device you're testing fixed to that version of iOS? Apple fixed some quirks with iOS 8's version of Safari in later updates. It's probably worth updating to 8.3 and then testing. |
Same behaviour on iOS 8.3 EDIT
EDIT 2 UPDATE
I had to enforce this code:
|
The demos on http://amsul.ca/pickadate.js/ do not work properly on iOS 8. I am only testing on an iPad but am aware of similar issues on iPhone.
The opaque background shows but the position of the calendar is way down at the bottom, so it can mean a lot of scrolling.
iOS 8 possibly changed how it handles CSS position: fixed?
The text was updated successfully, but these errors were encountered: