Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: View Query link in dashboards references "Mode" #546

Closed
jonhehir opened this issue Jul 9, 2020 · 2 comments
Closed

bug: View Query link in dashboards references "Mode" #546

jonhehir opened this issue Jul 9, 2020 · 2 comments
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior

Comments

@jonhehir
Copy link
Contributor

jonhehir commented Jul 9, 2020

The link to view a query for dashboards right now is hardcoded to say "View in Mode." This should render the appropriate dashboard product name.

Screenshot

image

Your Environment

Most recent version of amundsenfrontendlibrary.
@jonhehir jonhehir mentioned this issue Jul 9, 2020
Closed
@feng-tao feng-tao added good first issue Good for newcomers help wanted Extra attention is needed keep fresh Disables stalebot from closing an issue Project: Frontend status:needs_triage For all issues that need to be processed type:bug An unexpected problem or unintended behavior labels Jul 9, 2020
@feng-tao
Copy link
Member

feng-tao commented Jul 9, 2020

cc @ttannis @Golodhros
I wonder whether we could get the dashboard product from backend. At the very least, we could rename the wording to be more generic.

@ttannis ttannis added status:needs_votes Issue or bug fix that needs support from the community to be considered status:in_progress Issue that is being worked on right now and removed status:needs_triage For all issues that need to be processed status:needs_votes Issue or bug fix that needs support from the community to be considered labels Jul 9, 2020
@ttannis ttannis mentioned this issue Jul 14, 2020
Merged
5 tasks
@feng-tao feng-tao closed this as completed Aug 8, 2020
@feng-tao
Copy link
Member

feng-tao commented Aug 8, 2020

the change is merged.

dorianj pushed a commit to dorianj/amundsen that referenced this issue Apr 25, 2021
@Golodhros
feat: Announcements in Homepage (amundsen-io#591)
9e35c7e 
* feat: AnnouncementsList component (amundsen-io#540)

* Adds fake endpoint return for development

* Basic Announcements list

* Basic unstyled Announcements list

* Restoring proper announcements endpoint code

* Linting issues

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Announcements container and saga, api and reducer modifications (amundsen-io#541)

* Basic container

* Adding status code to announcement response

* Updating Announcements reducer, sagas and api to support loading and error states

* Linting details

* Completing the global state fixture

* Basic tests for connection

Signed-off-by: Marcos Iglesias <[email protected]>

* Basic card with loading shimmer (amundsen-io#546)

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Card Styling for announcements (amundsen-io#550)

* Shimmering card styles

* Basic card typography styling

* Add links and link styles to cards

* Adjusting card copy per Knowl specs

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Wiring announcements block on Homepage (amundsen-io#551)

* Adds announcemetns to homepage, integrates basic card

* Spacing and details

* Adjusting loading state

* Adds card and see more links logging

* Updates layout size; focus detail

* Variables on List component styles

* Cleaning fake response

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Adds config for announcements (amundsen-io#562)

* Moves config tests, adds config for announcements and test

Signed-off-by: Marcos Iglesias <[email protected]>

* Wiring announcements feature to the config option

Signed-off-by: Marcos Iglesias <[email protected]>

* Updating configuration docs

Signed-off-by: Marcos Iglesias <[email protected]>

* Extracting navLinks logic into the config utils

Signed-off-by: Marcos Iglesias <[email protected]>

* Adds LPL typography to announcements; some layout fine-tuning (amundsen-io#581)

Signed-off-by: Marcos Iglesias Valle <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Fixing merge conflicts

Signed-off-by: Marcos Iglesias <[email protected]>
feng-tao pushed a commit that referenced this issue May 7, 2021
@Golodhros
feat: Announcements in Homepage (#591)
f3216ce 
* feat: AnnouncementsList component (#540)

* Adds fake endpoint return for development

* Basic Announcements list

* Basic unstyled Announcements list

* Restoring proper announcements endpoint code

* Linting issues

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Announcements container and saga, api and reducer modifications (#541)

* Basic container

* Adding status code to announcement response

* Updating Announcements reducer, sagas and api to support loading and error states

* Linting details

* Completing the global state fixture

* Basic tests for connection

Signed-off-by: Marcos Iglesias <[email protected]>

* Basic card with loading shimmer (#546)

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Card Styling for announcements (#550)

* Shimmering card styles

* Basic card typography styling

* Add links and link styles to cards

* Adjusting card copy per Knowl specs

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Wiring announcements block on Homepage (#551)

* Adds announcemetns to homepage, integrates basic card

* Spacing and details

* Adjusting loading state

* Adds card and see more links logging

* Updates layout size; focus detail

* Variables on List component styles

* Cleaning fake response

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Adds config for announcements (#562)

* Moves config tests, adds config for announcements and test

Signed-off-by: Marcos Iglesias <[email protected]>

* Wiring announcements feature to the config option

Signed-off-by: Marcos Iglesias <[email protected]>

* Updating configuration docs

Signed-off-by: Marcos Iglesias <[email protected]>

* Extracting navLinks logic into the config utils

Signed-off-by: Marcos Iglesias <[email protected]>

* Adds LPL typography to announcements; some layout fine-tuning (#581)

Signed-off-by: Marcos Iglesias Valle <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Fixing merge conflicts

Signed-off-by: Marcos Iglesias <[email protected]>
hansadriaans pushed a commit to DataChefHQ/amundsen that referenced this issue Jun 30, 2022
@Golodhros
feat: Announcements in Homepage (amundsen-io#591)
f3f3761 
* feat: AnnouncementsList component (amundsen-io#540)

* Adds fake endpoint return for development

* Basic Announcements list

* Basic unstyled Announcements list

* Restoring proper announcements endpoint code

* Linting issues

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Announcements container and saga, api and reducer modifications (amundsen-io#541)

* Basic container

* Adding status code to announcement response

* Updating Announcements reducer, sagas and api to support loading and error states

* Linting details

* Completing the global state fixture

* Basic tests for connection

Signed-off-by: Marcos Iglesias <[email protected]>

* Basic card with loading shimmer (amundsen-io#546)

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Card Styling for announcements (amundsen-io#550)

* Shimmering card styles

* Basic card typography styling

* Add links and link styles to cards

* Adjusting card copy per Knowl specs

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Wiring announcements block on Homepage (amundsen-io#551)

* Adds announcemetns to homepage, integrates basic card

* Spacing and details

* Adjusting loading state

* Adds card and see more links logging

* Updates layout size; focus detail

* Variables on List component styles

* Cleaning fake response

Signed-off-by: Marcos Iglesias <[email protected]>

* feat: Adds config for announcements (amundsen-io#562)

* Moves config tests, adds config for announcements and test

Signed-off-by: Marcos Iglesias <[email protected]>

* Wiring announcements feature to the config option

Signed-off-by: Marcos Iglesias <[email protected]>

* Updating configuration docs

Signed-off-by: Marcos Iglesias <[email protected]>

* Extracting navLinks logic into the config utils

Signed-off-by: Marcos Iglesias <[email protected]>

* Adds LPL typography to announcements; some layout fine-tuning (amundsen-io#581)

Signed-off-by: Marcos Iglesias Valle <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>

* Fixing merge conflicts

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros Golodhros added status:completed Issue is completed and on master and removed help wanted Extra attention is needed good first issue Good for newcomers keep fresh Disables stalebot from closing an issue status:in_progress Issue that is being worked on right now labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:completed Issue is completed and on master type:bug An unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Golodhros @jonhehir @ttannis @feng-tao