Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes storybook installation #2017

Merged
merged 10 commits into from
Nov 1, 2022
Merged

fix: fixes storybook installation #2017

merged 10 commits into from
Nov 1, 2022

Conversation

Golodhros
Copy link
Member

@Golodhros Golodhros commented Oct 31, 2022

Summary of Changes

Fixes long-time broken Storybook installation
Updates Storybook, Webpack, and caniuse versions
Deprecates '@storybook/addon-knobs'
Cleans stuff around

Deals with #973

Tests

Manually tested

Screenshots

AMS

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros
Copy link
Member Author

Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Signed-off-by: Marcos Iglesias <[email protected]>
Copy link
Contributor

@kristenarmes kristenarmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Marcos Iglesias <[email protected]>
@Golodhros Golodhros requested a review from a team as a code owner November 1, 2022 00:07
@boring-cyborg boring-cyborg bot added the area:all Related to all the project label Nov 1, 2022
@Golodhros Golodhros merged commit a6e1c3d into main Nov 1, 2022
@Golodhros Golodhros deleted the storybook branch November 1, 2022 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:all Related to all the project area:frontend From the Frontend folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants