Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use TestConfig for FE container #948

Merged
merged 1 commit into from
Mar 8, 2021
Merged

fix: use TestConfig for FE container #948

merged 1 commit into from
Mar 8, 2021

Conversation

feng-tao
Copy link
Member

@feng-tao feng-tao commented Mar 7, 2021

Summary of Changes

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely, including a title prefix.
  • PR includes a summary of changes.
  • My commits follow the guidelines from "How to write a good git commit message"

@feng-tao feng-tao marked this pull request as ready for review March 8, 2021 23:50
@feng-tao feng-tao requested a review from a team as a code owner March 8, 2021 23:50
@feng-tao feng-tao requested a review from allisonsuarez March 8, 2021 23:50
@feng-tao feng-tao merged commit eacdefd into master Mar 8, 2021
@feng-tao feng-tao deleted the feng-tao-patch-1 branch March 8, 2021 23:52
markgrover pushed a commit to markgrover/amundsen that referenced this pull request Apr 12, 2021
@feng-tao @markgrover
fix: use TestConfig for FE container (amundsen-io#948)
f981372
dorianj pushed a commit to dorianj/amundsen that referenced this pull request Apr 25, 2021
@feng-tao
fix: use TestConfig for FE container (amundsen-io#948)
ac8703d
feng-tao added a commit that referenced this pull request May 7, 2021
@feng-tao
fix: use TestConfig for FE container (#948)
35740ea
prafullkotecha pushed a commit to prafullkotecha/amundsen that referenced this pull request May 19, 2021
@feng-tao
fix: use TestConfig for FE container (amundsen-io#948)
a6883c6 
Signed-off-by: GitHub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonsuarez allisonsuarez allisonsuarez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feng-tao @allisonsuarez