Fix Sample Scripts and Data

[jacobhjkim]

Summary of Changes

Currently, sample_data_loader.py is bugged. Therefore, I made some fixes.

This PR mostly changed schema_name -> schema and name -> full_name.

If you run sample_data_loader.py on the latest branch without making any changes, it will return this error.

Traceback (most recent call last):
  File "example/scripts/sample_data_loader.py", line 643, in <module>
    load_table_data_from_csv('sample_table_programmatic_source.csv', 'programmatic')
  File "example/scripts/sample_data_loader.py", line 89, in load_table_data_from_csv
    i['description_source']) for i in dr]
  File "example/scripts/sample_data_loader.py", line 89, in <listcomp>
    i['description_source']) for i in dr]
KeyError: 'schema'

Documentation / Unit Test

No need for either since this only changes example scripts.

Checklist

Make sure you have checked all steps below to ensure a timely review.

• PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
• PR includes a summary of changes.
• PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
• PR passes make test

[jacobhjkim]

However, there is still an issue in sample_data_loader.py and I am trying to fix it.
This one is also fixed.

Traceback (most recent call last):
  File "example/scripts/sample_data_loader.py", line 807, in <module>
    job_es_user.launch()
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/job/job.py", line 78, in launch
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/job/job.py", line 68, in launch
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/task/task.py", line 58, in run
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/extractor/neo4j_search_data_extractor.py", line 75, in extract
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/extractor/neo4j_extractor.py", line 101, in extract
  File "/usr/local/lib/python3.7/site-packages/amundsen_databuilder-2.0.0-py3.7.egg/databuilder/extractor/neo4j_extractor.py", line 86, in _get_extract_iter
TypeError: __init__() got an unexpected keyword argument 'name'

[codecov-io]

Codecov Report

Merging #199 into master will decrease coverage by 1.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
- Coverage   81.62%   80.18%   -1.45%     
==========================================
  Files          73       79       +6     
  Lines        3511     3669     +158     
  Branches      383      391       +8     
==========================================
+ Hits         2866     2942      +76     
- Misses        537      616      +79     
- Partials      108      111       +3

Impacted Files	Coverage Δ
databuilder/rest_api/rest_api_query.py	82.85% <0%> (-2.33%)	⬇️
...er/extractor/dashboard/mode_dashboard_extractor.py
...atabuilder/models/dashboard/dashboard_execution.py	71.05% <0%> (ø)
databuilder/transformer/dict_to_model.py	94.11% <0%> (ø)
...tabuilder/transformer/timestamp_string_to_epoch.py	87.5% <0%> (ø)
...e_analytics/mode_dashboard_executions_extractor.py	0% <0%> (ø)
...r/dashboard/mode_analytics/mode_dashboard_utils.py	0% <0%> (ø)
...shboard/mode_analytics/mode_dashboard_extractor.py	0% <0%> (ø)
...shboard/mode_analytics/mode_dashboard_constants.py	0% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dac8110...dac961a. Read the comment docs.

[samshuster]

Just noticed this as well. Heads up @jinhyukchang @feng-tao

[feng-tao]

@TheJacobKim lgtm, could you fix the CLA check(normally due to not config github user/email in your local env)? Thanks.

[friendtocephalopods]

Thanks for the fix!

[jacobhjkim]

Thanks @feng-tao, the CLA check issue was with my local git config. Is there a more elegant way to trigger the CLA check other than pushing a commit?

[feng-tao]

thanks @TheJacobKim ! I think that's the easier approach.