Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cast the read counts in the table usage models to be ints #410

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

AndrewCiambrone
Copy link
Contributor

@AndrewCiambrone AndrewCiambrone commented Nov 10, 2020

Signed-off-by: Andrew [email protected]

Summary of Changes

When the read counts are read from a csv they are read as a string not an integer. This ensures all read counts are ints.

Tests

What tests did you add or modify and why? If no tests were added or modified, explain why. Remove this line

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@AndrewCiambrone AndrewCiambrone changed the title fix: Cast the read counts to be ints fix: Cast the read counts in the table usage models to be ints Nov 10, 2020
@feng-tao feng-tao merged commit ea25770 into amundsen-io:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants