fix: Move grouped_tables into _retrieve_tables() in bigquery_metadata_extractor #430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xuans [email protected]
Summary of Changes
It is an update for my previous PR(#421) which uses dataset/table_prefix as the key of grouped_tables to solve the table key missing issue since some tables can share the same table_prefix in different datasets. I just noticed the Set self.grouped_tables is only used for a single function
_retrieve_tables()
in bigquery_metadata_extractor. If so, for fixing that issue, I would like to just move grouped_tables into_retrieve_tables()
which only works for a given dataset so that this set can still use table_prefix as the key. It is going to make the code change conciser.Tests
Documentation
CheckList
Make sure you have checked all steps below to ensure a timely review.
make test