fix: Increase the compatibility of id structure between the Databuilder and the Metadata Library

[AndrewCiambrone]

Summary of Changes

The gremlin metadata proxy uses two id fields. The first is the default id on the vertex. ~id and they use a field called key found: https://github.com/amundsen-io/amundsenmetadatalibrary/blob/master/metadata_service/proxy/neptune_proxy.py#L117

It would require rewriting most of the queries to consolidate the two id's and I am not sure how compatible it would be with the other gremlin databases.

Note: This looks like a large change but it is mostly testing changes. The majority of the logic changes occur in the neptune serializer.

Tests

Corrected all the ids on the models

Documentation

What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

• PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
• PR includes a summary of changes.
• PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
• PR passes make test

[feng-tao]

do we need to wait for https://github.com/amundsen-io/amundsenmetadatalibrary/pull/260/files to land?

[AndrewCiambrone]

Yeah I think we should wait incase I need to change some of the attribute names.

[feng-tao]

lgtm