Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for tags based on atlas terms #466

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

dechoma
Copy link
Contributor

@dechoma dechoma commented Mar 30, 2021

Signed-off-by: DOMINIK CHOMA [email protected]

Summary of Changes

Add support for table tags based on Apache Atlas glossary terms

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • [ x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • [ x] PR includes a summary of changes.
  • [x ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • [x ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • [ x] PR passes make test

@feng-tao
Copy link
Member

cc @mgorsk1

DOMINIK CHOMA added 2 commits March 31, 2021 08:30
Signed-off-by: DOMINIK CHOMA <[email protected]>
@mgorsk1
Copy link
Contributor

mgorsk1 commented Mar 31, 2021

lgtm, thanks @dechoma !

@mgorsk1 mgorsk1 merged commit cc1caf3 into amundsen-io:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants