Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled autocomplete for text and email input fields #375

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Disabled autocomplete for text and email input fields #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0dec5b
Disabled autocomplete for text and email input fields
Jan 22, 2020
9f0eaf9
Enabled autocomplete for the filters and removed the hard coded font …
Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions amundsen_application/static/css/_inputs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ input {
&:-webkit-autofill:hover,
&:-webkit-autofill:focus,
&:-webkit-autofill:active {
-webkit-box-shadow: 0 0 0px 1000px $white inset !important;
font-size: 20px !important;
-webkit-box-shadow: 0 0 0 1000px $white inset !important;
box-shadow: 0 0 0 1000px $white inset !important;
}

&[type="radio"] {
Expand Down
8 changes: 7 additions & 1 deletion ...en_application/static/js/components/Feedback/FeedbackForm/BugReportFeedbackForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ export class BugReportFeedbackForm extends AbstractFeedbackForm {
<input type="hidden" name="feedback-type" value="Bug Report"/>
<div className="form-group">
<label>{SUBJECT_LABEL}</label>
<input type="text" name="subject" className="form-control" required={ true } placeholder={SUBJECT_PLACEHOLDER} />
<input
type="text"
autoComplete="off"
name="subject"
className="form-control"
required={ true }
placeholder={SUBJECT_PLACEHOLDER} />
</div>
<div className="form-group">
<label>{BUG_SUMMARY_LABEL}</label>
Expand Down
8 changes: 7 additions & 1 deletion ...dsen_application/static/js/components/Feedback/FeedbackForm/RequestFeedbackForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@ export class RequestFeedbackForm extends AbstractFeedbackForm {
<input type="hidden" name="feedback-type" value="Feature Request"/>
<div className="form-group">
<label>{SUBJECT_LABEL}</label>
<input type="text" name="subject" className="form-control" required={ true } placeholder={SUBJECT_PLACEHOLDER} />
<input
type="text"
autoComplete="off"
name="subject"
className="form-control"
required={ true }
placeholder={SUBJECT_PLACEHOLDER} />
</div>
<div className="form-group">
<label>{FEATURE_SUMMARY_LABEL}</label>
Expand Down
3 changes: 2 additions & 1 deletion amundsen_application/static/js/components/SearchPage/SearchFilter/InputFilter/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ export class InputFilter extends React.Component<InputFilterProps, InputFilterSt
render = () => {
const { categoryId, disabled = false } = this.props;
return (
<form className="input-section-content" onSubmit={ this.onApplyChanges }>
<form className="input-section-content form-group" onSubmit={ this.onApplyChanges }>
<input
type="text"
className="form-control"
disabled={ disabled }
name={ categoryId }
onChange={ this.onInputChange }
Expand Down
18 changes: 16 additions & 2 deletions amundsen_application/static/js/components/TableDetail/RequestMetadataForm/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,11 +142,25 @@ export class RequestMetadataForm extends React.Component<RequestMetadataProps, R
<form onSubmit={ this.submitNotification } id="RequestForm">
<div id="sender-form-group" className="form-group">
<label>{FROM_LABEL}</label>
<input type="email" name="sender" className="form-control" required={true} value={userEmail} readOnly={true}/>
<input
type="email"
autoComplete="off"
name="sender"
className="form-control"
required={true}
value={userEmail}
readOnly={true} />
</div>
<div id="recipients-form-group" className="form-group">
<label>{TO_LABEL}</label>
<input type="text" name="recipients" className="form-control" required={true} multiple={true} defaultValue={tableOwners.join(RECIPIENT_LIST_DELIMETER)}/>
<input
type="text"
autoComplete="off"
name="recipients"
className="form-control"
required={true}
multiple={true}
defaultValue={tableOwners.join(RECIPIENT_LIST_DELIMETER)}/>
</div>
<div id="request-type-form-group" className="form-group">
<label>{REQUEST_TYPE}</label>
Expand Down