Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds configuration for PR title linting app #606

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

Golodhros
Copy link
Member

Summary of Changes

Adds settings for the PR linting app
Updates PR template

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@Golodhros Golodhros changed the title Adds configuration for PR title linting app chore: Adds configuration for PR title linting app Aug 21, 2020
@feng-tao
Copy link
Member

nice

@Golodhros Golodhros merged commit dba541c into master Aug 21, 2020
@feng-tao feng-tao deleted the miglesiasvalle-pr-lint-app branch August 22, 2020 16:54
@feng-tao
Copy link
Member

@Golodhros when you have a chance, it would be good to apply the same lint for all other repos.

@Golodhros
Copy link
Member Author

Yep, we'll test it for some days and see if it works properly. If so, I will propagate it through the rest of repos!

@dorianj
Copy link
Contributor

dorianj commented Nov 23, 2020

@Golodhros this doesn't appear to be picking up our config properly, our config in titleLint.xml is set to regex: (build|ci|docs|feat|fix|perf|refactor|style|test|chore|other): .*, but builds are also failing with:
Screen Shot 2020-11-23 at 12 19 19 PM

which is the default pattern.

also, the config page lists a totally different file, gitbots.yml:
Screen Shot 2020-11-23 at 12 19 19 PM

i can't find the actual code for this check, best I can tell it's this: https://github.com/githaxs/title-lint -- but that doesn't follow the format for github actions I've seen before (no action.xml file), so I don't think that's exactly the same.

I looked briefly and couldn't find any clear winner tool, but https://github.com/MorrisonCole/pr-lint-action seems to be actively developed -- should we give that a shot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants