-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Improves unit tests for ColumnType + QA fixes #625
Merged
ttannis
merged 6 commits into
feature/nested-column-types
from
ttannis_columntype-tests
Aug 31, 2020
Merged
test: Improves unit tests for ColumnType + QA fixes #625
ttannis
merged 6 commits into
feature/nested-column-types
from
ttannis_columntype-tests
Aug 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
Golodhros
reviewed
Aug 31, 2020
amundsen_application/static/js/components/TableDetail/ColumnListItem/ColumnType/index.tsx
Outdated
Show resolved
Hide resolved
Golodhros
reviewed
Aug 31, 2020
amundsen_application/static/js/components/TableDetail/ColumnListItem/ColumnType/parser.ts
Outdated
Show resolved
Hide resolved
Golodhros
reviewed
Aug 31, 2020
amundsen_application/static/js/components/TableDetail/ColumnListItem/ColumnType/styles.scss
Show resolved
Hide resolved
Golodhros
reviewed
Aug 31, 2020
amundsen_application/static/js/components/TableDetail/ColumnListItem/ColumnType/styles.scss
Show resolved
Hide resolved
Golodhros
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Some minor comments
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
ttannis
added a commit
that referenced
this pull request
Aug 31, 2020
* feat: Create ColumnType component (#604) * Create ColumnType component Signed-off-by: Tamika Tannis <[email protected]> * Update Modal UI Signed-off-by: Tamika Tannis <[email protected]> * Code cleanup; Add a test file * Prevent ColumnListItem expand/collapse from being triggered * Lint fix Signed-off-by: Tamika Tannis <[email protected]> * feat: Parse column types (#611) * WIP: Create a parser & render parsed text Signed-off-by: Tamika Tannis <[email protected]> * Cleanup logic Signed-off-by: Tamika Tannis <[email protected]> * More cleanup Signed-off-by: Tamika Tannis <[email protected]> * Lint fix Signed-off-by: Tamika Tannis <[email protected]> * Code cleanup Signed-off-by: Tamika Tannis <[email protected]> * Code cleanup Signed-off-by: Tamika Tannis <[email protected]> * Code cleanup Signed-off-by: Tamika Tannis <[email protected]> * Use more appropriate elements; Fix typo Signed-off-by: Tamika Tannis <[email protected]> * Parser tests Signed-off-by: Tamika Tannis <[email protected]> * Fix button; Fix test; Remove obsolete style Signed-off-by: Tamika Tannis <[email protected]> * Fix duplicate test name Signed-off-by: Tamika Tannis <[email protected]> * style: Improve UI styles and interactions (#617) * Vertically center modal Signed-off-by: Tamika Tannis <[email protected]> * Match design font specifications Signed-off-by: Tamika Tannis <[email protected]> * Miscellaneous cleanup Signed-off-by: Tamika Tannis <[email protected]> * Use variables Signed-off-by: Tamika Tannis <[email protected]> * test: Improves unit tests for ColumnType + QA fixes (#625) * Parser tests Signed-off-by: Tamika Tannis <[email protected]> * Updates from design qa Signed-off-by: Tamika Tannis <[email protected]> * Improve ColumnType tests Signed-off-by: Tamika Tannis <[email protected]> * log support Signed-off-by: Tamika Tannis <[email protected]> * Code cleanup Signed-off-by: Tamika Tannis <[email protected]> * Fix some lint warning Signed-off-by: Tamika Tannis <[email protected]> * Betterer update Signed-off-by: Tamika Tannis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR completes our code complete criteria for the targeted feature branch.
parser.ts
logic to cover an edge case in Presto types. (Commented asCase 3.1
in code, case is included in unit tests)Tests
parser.ts
, using similarly complicated structures found in production.ColummnType
Documentation
N/A for this feature.
CheckList
Make sure you have checked all steps below to ensure a timely review.