Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Improves unit tests for ColumnType + QA fixes #625

Merged
merged 6 commits into from
Aug 31, 2020

Conversation

ttannis
Copy link
Contributor

@ttannis ttannis commented Aug 31, 2020

Summary of Changes

This PR completes our code complete criteria for the targeted feature branch.

  1. Updates parser.ts logic to cover an edge case in Presto types. (Commented as Case 3.1 in code, case is included in unit tests)
  2. Updates styles based on design QA
  3. Support for logging click interaction on the column type button.

Tests

  1. Adds improved test coverage for parser.ts, using similarly complicated structures found in production.
  2. Adds improves test coverage for ColummnType

Documentation

N/A for this feature.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
@ttannis ttannis changed the title test: Improves unit tests for ColumnType test: Improves unit tests for ColumnType + QA fixes Aug 31, 2020
Copy link
Member

@Golodhros Golodhros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Some minor comments

Signed-off-by: Tamika Tannis <[email protected]>
Signed-off-by: Tamika Tannis <[email protected]>
@ttannis ttannis merged commit 361bec0 into feature/nested-column-types Aug 31, 2020
@ttannis ttannis deleted the ttannis_columntype-tests branch August 31, 2020 16:40
ttannis added a commit that referenced this pull request Aug 31, 2020
* feat: Create ColumnType component (#604)

* Create ColumnType component

Signed-off-by: Tamika Tannis <[email protected]>

* Update Modal UI

Signed-off-by: Tamika Tannis <[email protected]>

* Code cleanup; Add a test file

* Prevent ColumnListItem expand/collapse from being triggered

* Lint fix

Signed-off-by: Tamika Tannis <[email protected]>

* feat: Parse column types (#611)

* WIP: Create a parser & render parsed text

Signed-off-by: Tamika Tannis <[email protected]>

* Cleanup logic

Signed-off-by: Tamika Tannis <[email protected]>

* More cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Lint fix

Signed-off-by: Tamika Tannis <[email protected]>

* Code cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Code cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Code cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Use more appropriate elements; Fix typo

Signed-off-by: Tamika Tannis <[email protected]>

* Parser tests

Signed-off-by: Tamika Tannis <[email protected]>

* Fix button; Fix test; Remove obsolete style

Signed-off-by: Tamika Tannis <[email protected]>

* Fix duplicate test name

Signed-off-by: Tamika Tannis <[email protected]>

* style: Improve UI styles and interactions (#617)

* Vertically center modal

Signed-off-by: Tamika Tannis <[email protected]>

* Match design font specifications

Signed-off-by: Tamika Tannis <[email protected]>

* Miscellaneous cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Use variables

Signed-off-by: Tamika Tannis <[email protected]>

* test: Improves unit tests for ColumnType + QA fixes (#625)

* Parser tests

Signed-off-by: Tamika Tannis <[email protected]>

* Updates from design qa

Signed-off-by: Tamika Tannis <[email protected]>

* Improve ColumnType tests

Signed-off-by: Tamika Tannis <[email protected]>

* log support

Signed-off-by: Tamika Tannis <[email protected]>

* Code cleanup

Signed-off-by: Tamika Tannis <[email protected]>

* Fix some lint warning

Signed-off-by: Tamika Tannis <[email protected]>

* Betterer update

Signed-off-by: Tamika Tannis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants