Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds ability to use custom component on table #645

Merged
merged 2 commits into from
Sep 8, 2020
Merged

Conversation

Golodhros
Copy link
Member

Summary of Changes

Allows users of table to wrap cell values into other components

Tests

Added tests

Documentation

Added storybook

Storybook

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

Adds storybook and updates caption font

Signed-off-by: Marcos Iglesias <[email protected]>
Copy link
Contributor

@ttannis ttannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, for a real use case would the value be the component props?

@Golodhros
Copy link
Member Author

So, for a real use case would the value be the component props?

Yes, the value could be one of the component props, but most of the time they will be set beforehand.

@Golodhros Golodhros merged commit e73307a into master Sep 8, 2020
@ttannis ttannis deleted the mi-table-comp branch September 9, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants