Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adds React components naming conventions #713

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Conversation

Golodhros
Copy link
Member

Signed-off-by: Marcos Iglesias [email protected]

Summary of Changes

Adds a naming convention for component names and prop names
Include a summary of changes then remove this line

Documentation

It is documentation only
What documentation did you add or modify and why? Add any relevant links then remove this line

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes, including screenshots of any UI changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public python functions and the classes in the PR contain docstrings that explain what it does
  • PR passes all tests documented in the developer guide

@Golodhros Golodhros requested a review from a team as a code owner October 7, 2020 18:55
Copy link
Contributor

@ttannis ttannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean we plan on doing a mass renaming of things?

docs/react_naming_conventions.md Outdated Show resolved Hide resolved
@Golodhros
Copy link
Member Author

Does this mean we plan on doing a mass renaming of things?

Nah, I would say just on the new stuff or when we do some refactors. I don't think the amount of work would be worth it, do you agree?

@feng-tao
Copy link
Member

feng-tao commented Oct 8, 2020

Does this mean we plan on doing a mass renaming of things?

Nah, I would say just on the new stuff or when we do some refactors. I don't think the amount of work would be worth it, do you agree?

+1 for new as well as massive refactor may not bring that much benefit in the mean time you loss all the github blame around the code context.

@Golodhros Golodhros merged commit 284c91f into master Oct 9, 2020
@feng-tao feng-tao deleted the mi-fe-naming branch October 9, 2020 04:48
dikshathakur3119 pushed a commit that referenced this pull request Oct 15, 2020
Signed-off-by: Marcos Iglesias Valle <[email protected]>
Signed-off-by: dikshathakur3119 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants